Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDEA-358562 Fix build output 'Starting Daemon' event using Daemon JVM criteria #2888

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vmadalin
Copy link
Contributor

@vmadalin vmadalin commented Dec 6, 2024

Context

The Daemon toolchain was introduced in Gradle 8.8 and the motivation behind it and other technical details can be found on the public spec document. The implementation follows the agreed details on spec document and UI/UX document.

Summary

Given a project using Daemon JVM criteria when starting a daemon the event is captured multiple times on GradleProgressListener due to the fact that a new ProgressLoggerFactory.newOperation was nested on the original Starting Gradle Daemon as part of Daemon toolchain implementation. However, Gradle triggers always the parent event on completion resulting on the following:

Build
Starting Gradle Daemon
Discovering toolchains
Starting Gradle Daemon
Connecting to Gradle Daemon
Starting Gradle Daemon
Build

Before we had only Connecting to Gradle Daemon expecting only 2 Starting Gradle Daemon events, however, this isn't longer the case. For this reason, until a better way is provided by Gradle we are going to relay on the fact that latest Starting Gradle Daemon is always proceeded by Build, representing his parent.

Reported Gradle issue: gradle/gradle#31777

Tests

Overview

Starting Gradle Daemon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants