Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorting options to GitHub PR list filters #2870

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

LoayGhreeb
Copy link

Added sorting options to the GitHub pull request list filters, making it easier to sort PRs similarly to GitHub's interface. This includes options to sort by:

  • Newest/Oldest
  • Most/Least commented
  • Recently/Least recently updated

Screenshot:
image

@LoayGhreeb
Copy link
Author

Hi @iasemenov, could you please review this PR when you get a chance?

LoayGhreeb and others added 2 commits November 30, 2024 01:04
# Conflicts:
#	plugins/github/src/org/jetbrains/plugins/github/pullrequest/GHPRStatisticsCollector.kt
# Conflicts:
#	plugins/github/github-core/src/org/jetbrains/plugins/github/api/data/request/search/GithubIssueSearchSort.kt
@clemairej
Copy link
Collaborator

That's really cool! Thanks for contributing.
I'll take a look today.

@clemairej
Copy link
Collaborator

I see changing the sorting reloads the entire list. Kind of counter-intuitive, but definitely this contribution is not the place to fix that :)

Seems it's time to re-prioritise implementing dynamic local + API filtering...

Comment on lines +63 to +64
FILTER_LABEL_PRESENT,
FILTER_SORT_PRESENT)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the version number on line 29:
private val COUNTERS_GROUP = EventLogGroup("vcs.github.pullrequest.counters", ~~~ 9 ~~~)

We just need to do this for internal processes to respond accordingly every time we change anything in the collected statistics.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your feedback, @clemairej. I have updated the version.

@iasemenov iasemenov assigned clemairej and unassigned iasemenov Dec 16, 2024
@LoayGhreeb LoayGhreeb requested a review from clemairej December 16, 2024 16:34
@LoayGhreeb
Copy link
Author

I noticed another issue with the plugin. When trying to open the authors list to filter by an author, I see the error: "Must have push access to view repository collaborators".
I will investigate why this happens since the "Assignee" list opens normally and loads the repository collaborators, but will do this in a follow-up PR.

image

@clemairej
Copy link
Collaborator

Thanks for looking into this! Looks good to me, I'll merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants