-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sorting options to GitHub PR list filters #2870
base: master
Are you sure you want to change the base?
Conversation
Hi @iasemenov, could you please review this PR when you get a chance? |
# Conflicts: # plugins/github/src/org/jetbrains/plugins/github/pullrequest/GHPRStatisticsCollector.kt
# Conflicts: # plugins/github/github-core/src/org/jetbrains/plugins/github/api/data/request/search/GithubIssueSearchSort.kt
That's really cool! Thanks for contributing. |
I see changing the sorting reloads the entire list. Kind of counter-intuitive, but definitely this contribution is not the place to fix that :) Seems it's time to re-prioritise implementing dynamic local + API filtering... |
FILTER_LABEL_PRESENT, | ||
FILTER_SORT_PRESENT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please bump the version number on line 29:
private val COUNTERS_GROUP = EventLogGroup("vcs.github.pullrequest.counters", ~~~ 9 ~~~)
We just need to do this for internal processes to respond accordingly every time we change anything in the collected statistics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your feedback, @clemairej. I have updated the version.
I noticed another issue with the plugin. When trying to open the authors list to filter by an author, I see the error: "Must have push access to view repository collaborators". |
Thanks for looking into this! Looks good to me, I'll merge it. |
Added sorting options to the GitHub pull request list filters, making it easier to sort PRs similarly to GitHub's interface. This includes options to sort by:
Screenshot: