Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: workaround flaky CI test runner #1550

Merged
merged 3 commits into from
Dec 7, 2021
Merged

web: workaround flaky CI test runner #1550

merged 3 commits into from
Dec 7, 2021

Conversation

eymar
Copy link
Collaborator

@eymar eymar commented Dec 6, 2021

Sometimes our builds on teamcity fail with following errors:

UncaughtException: TypeError: Cannot read property 'consoleResultCollector' of undefined
      at KarmaKotlinReporter.onBrowserLog (/mnt/agent/work/cf85b5b43f56097b/web/build/js/packages_imported/kotlin-test-js-runner/1.5.31/karma-kotlin-reporter.js:190:27)
      at Server.<anonymous> (/mnt/agent/work/cf85b5b43f56097b/web/build/js/node_modules/karma/lib/events.js:40:26)
      at Server.emit (events.js:376:20)
      at Browser.onInfo (/mnt/agent/work/cf85b5b43f56097b/web/build/js/node_modules/karma/lib/browser.js:65:20)
      at Socket.<anonymous> (/mnt/agent/work/cf85b5b43f56097b/web/build/js/node_modules/karma/lib/browser.js:217:38)
      at Socket.emit (events.js:376:20)
      at /mnt/agent/work/cf85b5b43f56097b/web/build/js/node_modules/socket.io/dist/socket.js:435:32
      at processTicksAndRejections (internal/process/task_queues.js:77:11)
  TypeError: Cannot read property 'consoleResultCollector' of undefined
      at KarmaKotlinReporter.onBrowserLog (/mnt/agent/work/cf85b5b43f56097b/web/build/js/packages_imported/kotlin-test-js-runner/1.5.31/karma-kotlin-reporter.js:190:27)
      at Server.<anonymous> (/mnt/agent/work/cf85b5b43f56097b/web/build/js/node_modules/karma/lib/events.js:40:26)
      at Server.emit (events.js:376:20)
      at Browser.onInfo (/mnt/agent/work/cf85b5b43f56097b/web/build/js/node_modules/karma/lib/browser.js:65:20)
      at Socket.<anonymous> (/mnt/agent/work/cf85b5b43f56097b/web/build/js/node_modules/karma/lib/browser.js:217:38)
      at Socket.emit (events.js:376:20)
      at /mnt/agent/work/cf85b5b43f56097b/web/build/js/node_modules/socket.io/dist/socket.js:435:32
      at processTicksAndRejections (internal/process/task_queues.js:77:11)
  UncaughtException: TypeError: Cannot read property 'log' of undefined
      at KarmaKotlinReporter.getLog (/mnt/agent/work/cf85b5b43f56097b/web/build/js/packages_imported/kotlin-test-js-runner/1.5.31/karma-kotlin-reporter.js:260:35)
      at KarmaKotlinReporter.specSuccess (/mnt/agent/work/cf85b5b43f56097b/web/build/js/packages_imported/kotlin-test-js-runner/1.5.31/karma-kotlin-reporter.js:201:26)
      at KarmaKotlinReporter.BaseReporter.onSpecComplete (/mnt/agent/work/cf85b5b43f56097b/web/build/js/node_modules/karma/lib/reporters/base.js:107:12)
      at Server.<anonymous> (/mnt/agent/work/cf85b5b43f56097b/web/build/js/node_modules/karma/lib/events.js:40:26)
      at Server.emit (events.js:376:20)
      at Browser.onResult (/mnt/agent/work/cf85b5b43f56097b/web/build/js/node_modules/karma/lib/browser.js:164:20)
      at Socket.<anonymous> (/mnt/agent/work/cf85b5b43f56097b/web/build/js/node_modules/karma/lib/browser.js:218:42)
      at Socket.emit (events.js:376:20)
      at /mnt/agent/work/cf85b5b43f56097b/web/build/js/node_modules/socket.io/dist/socket.js:435:32
      at processTicksAndRejections (internal/process/task_queues.js:77:11)

The WA was taken from karma-runner/karma-teamcity-reporter#86 (adjusted a bit according to recent files structure in build dir)

@eymar eymar requested a review from Schahen December 6, 2021 12:41
@eymar eymar merged commit 046f225 into master Dec 7, 2021
@eymar eymar deleted the web/ci_issue_with_test_runner branch December 7, 2021 16:40
mareklangiewicz pushed a commit to mareklangiewicz/compose-jb that referenced this pull request Feb 14, 2022
@eymar @Schahen @mareklangiewicz
web: workaround flaky CI test runner (JetBrains#1550)
9eff8d3 
* web: workaround flaky CI test runner

* Move config path to test-utils/conf/karma.config.common.d

* Reusing same karma config everywhere aprt benchmarks

it looks like we can have only one karma config directory

Co-authored-by: Oleksandr Karpovich <[email protected]>
Co-authored-by: Shagen Ogandzhanian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Schahen Schahen Schahen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eymar @Schahen