Sourcery refactored master branch

[sourcery-ai]

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

[sourcery-ai]

Lines 9-62 refactored with the following changes:

• Move assignment closer to its usage within a block (move-assign-in-block)
• Convert for loop into list comprehension (list-comprehension)

This removes the following comments ( why? ):

# Index for the name of the ship in shipPartCounts
# Initalising shipList.

[sourcery-ai]

Function main refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)
• Remove redundant conditional (remove-redundant-if)

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.23%.

Quality metrics	Before	After	Change
Complexity	4.89 ⭐	4.66 ⭐	-0.23 👍
Method Length	83.75 🙂	83.50 🙂	-0.25 👍
Working memory	8.29 🙂	8.36 🙂	0.07 👎
Quality	65.74% 🙂	65.97% 🙂	0.23% 👍

Other metrics	Before	After	Change
Lines	212	227	15

Changed files	Quality Before	Quality After	Quality Change
scripts/eveConsts.py	68.71% 🙂	69.92% 🙂	1.21% 👍
scripts/ships.py	65.40% 🙂	65.59% 🙂	0.19% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
scripts/ships.py	main	9 🙂	211 ⛔	13 😞	43.62% 😞	Try splitting into smaller methods. Extract out complex expressions
scripts/ships.py	ship_parts_cost	12 🙂	185 😞	11 😞	46.20% 😞	Try splitting into smaller methods. Extract out complex expressions
scripts/ships.py	get_appraisal	0 ⭐	114 🙂	10 😞	67.14% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!