Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reset matches when testing an empty UA #529

Merged
merged 1 commit into from
Jun 7, 2024
Merged

reset matches when testing an empty UA #529

merged 1 commit into from
Jun 7, 2024

Conversation

tbussmann
Copy link
Contributor

Make sure, getMatches will not return stale data if the last test was performed for an empty UA or only consists of excluded patterns.

@tbussmann
reset matches when testing an empty UA
f0f29f5 
Make sure, getMatches will not return stale data if the last test was
performed for an empty UA or only consists of excluded patterns.
@tbussmann
Copy link
Contributor Author

tbussmann commented May 30, 2024 •
edited
Loading

We could furthermore reset the $matches when setUserAgent or setHttpHeaders is executed but this would be a change in behaviour.

@JayBizzle
Copy link
Owner

Thank you ❤️

@JayBizzle JayBizzle merged commit 8724b91 into JayBizzle:master Jun 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbussmann @JayBizzle