Skip to content

Commit

Permalink
Change current->state to __set_current_state() for 5.x
Browse files Browse the repository at this point in the history
  • Loading branch information
@JamesRHarris
JamesRHarris committed Oct 21, 2021
1 parent 81acc2c commit 5ae8395
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ctn91xx_event.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ ssize_t ctn91xx_event_read_common(ctn91xx_dev_t* dev, char __user * data, size_t
ctn91xx_event_cleanup(dev, event);
}

current->state = TASK_RUNNING;
__set_current_state(TASK_RUNNING);
remove_wait_queue(&dev->event_waitqueue, &wait);

return retval;
Expand Down

1 comment on commit 5ae8395

@phantasyconcepts
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey James,

Excellent work maintaining this driver. I still need it for my MythTV box. What I am running into , however, has me stumped. I am running the 5.14.0-58.el9.x86_64 on Centos 9 Stream (I had issues with Centos 8 Stream and Centos 8 just stopped updating due to its End of life). I have an ASUS Prime board that quit working on me, so I updated to the TUF Gaming board, both have the X570 chipset. I put a Ryzen 9 5950X processor on this baby and have a Radeon 670 RX GPU. All componenes worked with the Ryzen 3 3200G card on the Prime board and apparently I did some damage to the Prime board when removing the GPU or else I tuned the wrong setting on the memory upgrades and it went dark on me. Regardless, hardware-wise, things are working. I did have some issues with the driver installing on the kernel before I turned off the lousy 'Secure Boot' crap , but here is where it gets weird. The card will take an IP address, but it won't route traffic to the web address. I reseated and swapped ports on the board multiple times. This is my only InfiniTV6 card, so I really hope it didn't just die a horrible death. It seems to be giving multiple ctn91xx_net)tx_timeout messages in the logs, so I booted into the debug kernel and rebuilt the driver under that one. I already ruled out the usual suspects - SELinux is off, and so is the firewall.NMAP tells me all ports are filtered, though, sometimes, while others it tells me I have 0 hosts up. I was about to configure logging but wanted to know if you had any idea what the imtcp settings should be to get more info from the card.

Here are the logs without that TCP data. The timeouts are suspicious. It looks like the driver is installed properly, just not working as a NIC.

debugout.txt

[ 697.834305] ctn91xx: loading out-of-tree module taints kernel.
[ 697.834407] ctn91xx: module verification failed: signature and/or required key missing - tainting kernel
[ 697.855795] ctn91xx 0000:07:00.0: enabling device (0000 -> 0002)
[ 697.856367] ctn91xx_register:70 : (0) IO hw_reg_base address: fc500000
[ 697.856371] ctn91xx_register:71 : (0) reg_base: 000000006b36db30
[ 697.856401] ctn91xx_register:79 : (0) IO translation_hw_reg_base address: fc520000
[ 697.856404] ctn91xx_register:80 : (0) translation_reg_base: 000000005ed6ad12
[ 697.856412] ctn91xx_register:107 : (0) system clock freq 100000000, ticks per us 100
[ 697.856419] ctn91xx_register:136 : (0) face detected as present
[ 697.856484] ctn91xx_reset_all:102 : (0) reset all
[ 697.859273] ctn91xx_register:171 : (0) Driver initialization successful for CTN-9120 v6252
[ 697.863617] ctn91xx_register:194 : (0) irq: 40
[ 697.895491] ctn91xx 0000:07:00.0 enp7s0: renamed from ctn0
[ 704.650504] ------------[ cut here ]------------
[ 704.650542] NETDEV WATCHDOG: enp7s0 (ctn91xx): transmit queue 0 timed out
[ 704.650559] WARNING: CPU: 3 PID: 0 at net/sched/sch_generic.c:477 dev_watchdog+0x8fc/0xaf0
[ 704.650571] Modules linked in: ctn91xx(OE) uinput rfcomm snd_seq_dummy snd_hrtimer qrtr ns bnep sunrpc vfat fat intel_rapl_msr intel_rapl_common snd_hda_codec_realtek iwlmvm snd_hda_codec_generic ledtrig_audio snd_hda_codec_hdmi snd_hda_intel edac_mce_amd snd_intel_dspcfg snd_intel_sdw_acpi mac80211 snd_usb_audio snd_hda_codec raid0 libarc4 snd_hda_core snd_usbmidi_lib snd_hwdep kvm snd_rawmidi uvcvideo snd_seq snd_seq_device videobuf2_vmalloc videobuf2_memops videobuf2_v4l2 irqbypass videobuf2_common eeepc_wmi iwlwifi snd_pcm btusb rapl asus_wmi btrtl videodev btbcm sparse_keymap btintel mc pcspkr bluetooth snd_timer video wmi_bmof joydev k10temp i2c_piix4 cfg80211 snd ecdh_generic soundcore ecc rfkill acpi_cpufreq xfs libcrc32c sd_mod sg amdgpu drm_ttm_helper ttm iommu_v2 gpu_sched crct10dif_pclmul i2c_algo_bit crc32_pclmul drm_kms_helper crc32c_intel syscopyarea sysfillrect sysimgblt fb_sys_fops cec ghash_clmulni_intel drm sp5100_tco ccp ahci libahci libata nvme r8169 nvme_core
[ 704.650957] realtek t10_pi wmi hid_logitech_hidpp hid_logitech_dj dm_mirror dm_region_hash dm_log dm_mod fuse
[ 704.651000] CPU: 3 PID: 0 Comm: swapper/3 Kdump: loaded Tainted: G W OE --------- --- 5.14.0-58.el9.x86_64+debug #1
[ 704.651006] Hardware name: System manufacturer System Product Name/TUF GAMING X570-PLUS (WI-FI), BIOS 4005 07/13/2021
[ 704.651011] RIP: 0010:dev_watchdog+0x8fc/0xaf0
[ 704.651018] Code: ff 4c 8b 7c 24 28 c6 05 44 b0 50 02 01 4c 89 ff e8 49 c6 e9 ff 44 89 e1 4c 89 fe 48 c7 c7 40 0b ce 96 48 89 c2 e8 1f 90 56 00 <0f> 0b e9 ad fd ff ff e8 48 92 61 00 85 c0 74 b0 80 3d aa a8 50 02
[ 704.651023] RSP: 0018:ffffc900004f0c80 EFLAGS: 00010286
[ 704.651032] RAX: 0000000000000000 RBX: ffff888277d04508 RCX: 0000000000000000
[ 704.651037] RDX: 0000000000000103 RSI: 0000000000000008 RDI: fffff5200009e182
[ 704.651041] RBP: ffffffff982763b4 R08: 0000000000000000 R09: ffffffff982726a7
[ 704.651046] R10: fffffbfff304e4d4 R11: 0000000000000001 R12: 0000000000000000
[ 704.651050] R13: 0000000000000003 R14: ffff8882bf8bd800 R15: ffff888277d04000
[ 704.651055] FS: 0000000000000000(0000) GS:ffff889f5ca00000(0000) knlGS:0000000000000000
[ 704.651060] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 704.651065] CR2: 00007fe76716f1d8 CR3: 0000000185a6e000 CR4: 0000000000750ee0
[ 704.651070] PKRU: 55555554
[ 704.651074] Call Trace:
[ 704.651078]
[ 704.651095] call_timer_fn+0x1a5/0x5c0
[ 704.651103] ? dequeue_skb+0x1710/0x1710
[ 704.651112] ? lock_downgrade+0x130/0x130
[ 704.651125] ? msleep_interruptible+0x130/0x130
[ 704.651153] ? lockdep_hardirqs_on_prepare.part.0+0x18c/0x370
[ 704.651167] __run_timers.part.0+0x573/0x950
[ 704.651174] ? dequeue_skb+0x1710/0x1710
[ 704.651188] ? call_timer_fn+0x5c0/0x5c0
[ 704.651197] ? clockevents_program_event+0xe2/0x280
[ 704.651205] ? clockevents_program_event+0xe2/0x280
[ 704.651215] ? sched_clock_cpu+0x15/0x1b0
[ 704.651221] ? lapic_next_event+0x57/0x90
[ 704.651233] run_timer_softirq+0x9c/0x180
[ 704.651241] __do_softirq+0x2d3/0x9a4
[ 704.651258] __irq_exit_rcu+0x1f4/0x2a0
[ 704.651266] irq_exit_rcu+0xa/0x20
[ 704.651271] sysvec_apic_timer_interrupt+0x93/0xc0
[ 704.651278]
[ 704.651283] asm_sysvec_apic_timer_interrupt+0x12/0x20
[ 704.651289] RIP: 0010:cpuidle_enter_state+0x1f8/0x8d0
[ 704.651296] Code: 00 41 8b 77 04 bf ff ff ff ff e8 93 f0 ff ff 31 ff e8 dc 5a aa fe 80 7c 24 08 00 0f 85 9e 01 00 00 e8 5c cb d9 fe fb 45 85 e4 <0f> 88 8c 02 00 00 49 63 ec 48 8d 44 6d 00 48 8d 44 85 00 48 8d 7c
[ 704.651301] RSP: 0018:ffffc9000021fd70 EFLAGS: 00000202
[ 704.651310] RAX: 000000000005f3e3 RBX: ffffffff97f222a0 RCX: 1ffffffff304e119
[ 704.651314] RDX: 0000000000000000 RSI: ffffffff968a4b80 RDI: ffffffff96a7ff00
[ 704.651318] RBP: 0000000000000002 R08: 0000000000000001 R09: ffffffff98275927
[ 704.651321] R10: fffffbfff304eb24 R11: 0000000000000001 R12: 0000000000000002
[ 704.651324] R13: ffff8881c8dc9004 R14: 000000a4106fa708 R15: ffff8881c8dc9000
[ 704.651344] cpuidle_enter+0x4a/0xa0
[ 704.651351] cpuidle_idle_call+0x279/0x3f0
[ 704.651356] ? arch_cpu_idle_exit+0x40/0x40
[ 704.651363] ? tsc_verify_tsc_adjust+0x5d/0x2e0
[ 704.651370] do_idle+0x12a/0x200
[ 704.651377] cpu_startup_entry+0x19/0x20
[ 704.651382] start_secondary+0x2b9/0x3a0
[ 704.651387] ? set_cpu_sibling_map+0x2280/0x2280
[ 704.651392] ? set_bringup_idt_handler.constprop.0+0x88/0x90
[ 704.651399] ? start_cpu0+0xc/0xc
[ 704.651405] secondary_startup_64_no_verify+0xc2/0xcb
[ 704.651420] irq event stamp: 391456
[ 704.651423] hardirqs last enabled at (391464): [] asm_sysvec_irq_work+0x12/0x20
[ 704.651428] hardirqs last disabled at (391471): [] sysvec_irq_work+0xb/0xc0
[ 704.651433] softirqs last enabled at (390040): [] __do_softirq+0x621/0x9a4
[ 704.651437] softirqs last disabled at (390117): [] __irq_exit_rcu+0x1f4/0x2a0
[ 704.651442] ---[ end trace 09d21c4c8c24a51f ]---
[ 704.651460] ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
[ 710.794344] ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
[ 717.450269] ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
[ 723.593986] ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
[ 729.737829] ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
[ 736.906091] ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
[ 743.561994] ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
[ 749.705907] ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)

[ 1469.425359] ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
[ 1475.568893] ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
[ 1481.712370] ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
[ 1488.367846] ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
[ 1494.511697] ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
[ 1500.655136] ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
[ 1507.822757] ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
[ 1529.593832] ctn91xx_register:70 : (0) IO hw_reg_base address: fc500000
[ 1529.593839] ctn91xx_register:71 : (0) reg_base: 00000000700bb89b
[ 1529.593863] ctn91xx_register:79 : (0) IO translation_hw_reg_base address: fc520000
[ 1529.593865] ctn91xx_register:80 : (0) translation_reg_base: 000000000448d56a
[ 1529.593873] ctn91xx_register:107 : (0) system clock freq 100000000, ticks per us 100
[ 1529.593881] ctn91xx_register:136 : (0) face detected as present
[ 1529.593935] ctn91xx_reset_all:102 : (0) reset all
[ 1529.596709] ctn91xx_register:171 : (0) Driver initialization successful for CTN-9120 v6252
[ 1529.600580] ctn91xx_register:194 : (0) irq: 40
[ 1529.626420] ctn91xx 0000:07:00.0 enp7s0: renamed from ctn0
[ 1536.494136] ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
[ 1543.661958] ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
[ 1550.318205] ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)

Feb 21 23:26:58 localhost ModemManager[1491]: [base-manager] couldn't check support for device '/sys/devices/pci0000:00/0000:00:01.2/0000:02:00.0/0000:03:06.0/0000:07:00.0': not supported by any plugin
Feb 21 23:27:03 localhost kernel: ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
Feb 21 23:27:06 localhost systemd[1]: NetworkManager-dispatcher.service: Deactivated successfully.
Feb 21 23:27:10 localhost kernel: ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
Feb 21 23:27:12 localhost NetworkManager[1360]: [1645504032.5015] dhcp6 (enp6s0): state changed new lease, address=fc00::15b
Feb 21 23:27:16 localhost kernel: ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
Feb 21 23:27:23 localhost kernel: ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
Feb 21 23:27:29 localhost kernel: ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
Feb 21 23:27:34 localhost gnome-shell[4433]: libinput error: event7 - Logitech G903 LS: client bug: event processing lagging behind by 27ms, your system is too slow
Feb 21 23:27:35 localhost kernel: ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
Feb 21 23:27:37 localhost gnome-shell[4433]: libinput error: event7 - Logitech G903 LS: client bug: event processing lagging behind by 16ms, your system is too slow
Feb 21 23:27:39 localhost gnome-shell[4433]: libinput error: event7 - Logitech G903 LS: client bug: event processing lagging behind by 18ms, your system is too slow
Feb 21 23:27:39 localhost gnome-shell[4433]: libinput error: event7 - Logitech G903 LS: WARNING: log rate limit exceeded (5 msgs per 60min). Discarding future messages.
Feb 21 23:27:40 localhost gnome-shell[4433]: libinput error: client bug: timer event7 debounce short: scheduled expiry is in the past (-1ms), your system is too slow
Feb 21 23:27:41 localhost kernel: ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
Feb 21 23:27:48 localhost kernel: ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
Feb 21 23:27:55 localhost kernel: ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
Feb 21 23:28:01 localhost kernel: ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
Feb 21 23:28:08 localhost kernel: ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
Feb 21 23:28:15 localhost kernel: ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
Feb 21 23:28:21 localhost kernel: ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
Feb 21 23:28:28 localhost kernel: ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
Feb 21 23:28:35 localhost kernel: ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
Feb 21 23:28:41 localhost kernel: ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
Feb 21 23:28:47 localhost kernel: ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
Feb 21 23:28:54 localhost kernel: ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
Feb 21 23:29:00 localhost kernel: ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
Feb 21 23:29:06 localhost kernel: ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
Feb 21 23:29:13 localhost kernel: ctn91xx_net_tx_timeout:195 : (0) tx timeout (eth_pend=1, tx_pen=1 recv=1 skb=1 valid=1)
Feb 21 23:29:18 localhost NetworkManager[1360]: [1645504158.7380] device (wlp5s0): set-hw-addr: set MAC address to AA:15:07:B7:A7:58 (scanning)
Feb 21 23:29:18 localhost NetworkManager[1360]: [1645504158.7547] device (wlp5s0): supplicant interface state: inactive -> disconnected
Feb 21 23:29:18 localhost NetworkManager[1360]: [1645504158.7548] device (p2p-dev-wlp5s0): supplicant management interface state: inactive -> disconnected
Feb 21 23:29:18 localhost NetworkManager[1360]: [1645504158.7599] device (wlp5s0): supplicant interface state: disconnected -> inactive
Feb 21 23:29:18 localhost NetworkManager[1360]: [1645504158.7599] device (p2p-dev-wlp5s0): supplicant management interface state: disconnected -> inactive

Please sign in to comment.