Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nested reorder components (stop propagation on item down) #93

Open
wants to merge 1 commit into
base: rework
Choose a base branch
from
Open

Conversation

cyberpluto
Copy link

This allows to work with nested Reorder components, otherwise all nested elements drag together :)

This allows to work with nested Reorder components.
@JakeSidSmith JakeSidSmith changed the title Stop propagation Allow nested reorder components (stop propagation on item down) Nov 22, 2017
@JakeSidSmith
Copy link
Owner

@cyberpluto I wouldn't want to add this to the library in this way as there would be no way to not prevent the stopPropagation. However, allowing a user to manually call stopPropagation would be fine. Or perhaps a prop that stops propagation.

Adding a callback for onItemDown would allow a user to manually call this. Would that be a suitable solution for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants