Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find the title from second page #12157

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

leaf-soba
Copy link
Contributor

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

find the title from second page
@@ -232,7 +232,7 @@ public TitleExtractorByFontSize() {

public String getTitleFromFirstPage(PDDocument document) throws IOException {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method name does not match the content of the method any more.

fix method name
@leaf-soba leaf-soba requested a review from koppor November 6, 2024 00:55
@calixtus
Copy link
Member

calixtus commented Nov 7, 2024

I believe we need to find or create a test file to move forward here. Maybe we can ask the university if they can provide an mit licensed test file?

add a unit test file with a test cover page
@koppor
Copy link
Member

koppor commented Nov 11, 2024

Test PDF not OK - the title page is OK, but the subsequent PDF not

image

You can use for example following paper: src\test\resources\pdfs\IEEE\ieee-paper.pdf as content for pages 2 onwards.

I bought an Acrobat Professional X for 10€ some years ago. - I think, other PDF tools such as PDFSam also work to create a PDF.

Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test PDF needs to be updated.

I love consistency - and the title page should somehow match the PDF attached. You can also create a new PDF based on src\test\resources\pdfs\IEEE)

change unit test cover page file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants