-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
find the title from second page #12157
base: main
Are you sure you want to change the base?
Conversation
find the title from second page
@@ -232,7 +232,7 @@ public TitleExtractorByFontSize() { | |||
|
|||
public String getTitleFromFirstPage(PDDocument document) throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method name does not match the content of the method any more.
fix method name
I believe we need to find or create a test file to move forward here. Maybe we can ask the university if they can provide an mit licensed test file? |
add a unit test file with a test cover page
Test PDF not OK - the title page is OK, but the subsequent PDF not You can use for example following paper: I bought an Acrobat Professional X for 10€ some years ago. - I think, other PDF tools such as PDFSam also work to create a PDF. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test PDF needs to be updated.
I love consistency - and the title page should somehow match the PDF attached. You can also create a new PDF based on src\test\resources\pdfs\IEEE
)
change unit test cover page file
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)