Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "view as BibTeX" option before importing an entry from the cita… #11847

Merged
merged 8 commits into from
Oct 3, 2024

Conversation

JamseBonde007
Copy link
Contributor

@JamseBonde007 JamseBonde007 commented Sep 29, 2024

Add a "view as BibTeX" option before importing an entry from the cita…tion relation tab #11826

This PR implements the feature requested in issue #10869. It adds a button that allows users to display a dialog showing the full BibTeX entry when importing citations from the Citation Relation tab. This enhancement will help users decide whether to import a potentially "duplicate" record by allowing them to see the full details of the entry in BibTeX format.

image
image

Closes #11826

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@JamseBonde007
Copy link
Contributor Author

Thank you for your feedback! I've addressed the issues you pointed out and made the necessary changes. Please take a look and let me know if everything looks good now.

@JamseBonde007
Copy link
Contributor Author

Thank you for the feedback and the tips! I've addressed the comments and reviewed the code in IntelliJ. Please take a look at the updates and let me know if everything looks good.

@JamseBonde007
Copy link
Contributor Author

Fixed

Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my point of view looks good!
Thanks for the contribution

Please resolve the comments you addressed, makes it easier for us to see which ones you fixed etc

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 30, 2024
@Siedlerchr Siedlerchr added this pull request to the merge queue Oct 3, 2024
Merged via the queue into JabRef:main with commit d3c7e51 Oct 3, 2024
23 checks passed
@Siedlerchr
Copy link
Member

@JamseBonde007 Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a "view as BibTeX" option before importing an entry from the citation relation tab
3 participants