Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commenting functionality #11672

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Add commenting functionality #11672

merged 1 commit into from
Aug 26, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Aug 25, 2024

Follow-up to #11615

Idea taken from spring-projects/spring-security#15477.

Together with @AlexanderGirgis, I wrote ghcommentpr to enable easy commenting.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Copy link
Contributor

github-actions bot commented Aug 25, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor koppor enabled auto-merge August 25, 2024 21:22
@koppor koppor added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit 1620002 Aug 26, 2024
22 checks passed
@koppor koppor deleted the add-auto-comment branch August 26, 2024 18:20
viktorkrimstein added a commit to viktorkrimstein/jabref that referenced this pull request Aug 27, 2024
* main:
  Rename ghprcomment.yaml to ghprcomment.yml
  Add commenting functionality (JabRef#11672)
  Bump io.github.classgraph:classgraph from 4.8.174 to 4.8.175 (JabRef#11676)
  Bump io.github.stefanbratanov:jvm-openai from 0.9.3 to 0.10.0 (JabRef#11680)
  Bump com.puppycrawl.tools:checkstyle from 10.17.0 to 10.18.0 (JabRef#11679)
  Bump com.h2database:h2-mvstore from 2.3.230 to 2.3.232 (JabRef#11678)
  Bump org.postgresql:postgresql from 42.7.3 to 42.7.4 (JabRef#11677)
  Bump src/main/resources/csl-styles from `d9989a2` to `35ac18d` (JabRef#11675)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants