Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right click create group #11476

Open
wants to merge 38 commits into
base: main
Choose a base branch
from

Commits on Jul 5, 2024

  1. Auto-Select Newly Created Group

    When a new group is added, that group will automatically be selected and focused.
    m-peeler committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    910c857 View commit details
    Browse the repository at this point in the history
  2. Update CHANGELOG.md

    Updated changelog to reflect updates.
    m-peeler committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    cbc0d7d View commit details
    Browse the repository at this point in the history
  3. Implemented "Current selection" group option

    Added new option to the "Group Options" in the GroupDialog to allow the creation of a group that contains the currently selected entries. If there are no entries selected, this option is disabled. If there is more than one entry selected, this option is selected by default.
    m-peeler committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    f126974 View commit details
    Browse the repository at this point in the history
  4. Addressed Style and Property Name Errors

    Fixes failed unit test (keyValueShouldBeEqualForEnglishPropertiesMessages) and style test ( '(' is preceded with whitespace.)
    m-peeler committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    e4c2281 View commit details
    Browse the repository at this point in the history
  5. Created 'Create Group From Selection' action

    Created the 'Create group from Seletion' item for the right-click menu and a new item on the menu. Began refactoring GroupDialogView, GroupDialogViewModel and GroupTreeViewModel to allow for creating a DialogView that automatically prioritizes 'Current selection'.
    m-peeler committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    9b4d2db View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9631067 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d4222a7 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2024

  1. Worked to implement right-click-to-make-group functionality

    Attempted to implement right-click-to-add functionality to the codebase. This ran into several problems and a few Gordian knots which I was attempting, and failing, to untie.
    
    This work included using a standardized SimpleCommand to launch the GroupDialogView each time, and accessed the parameters for that through the StateManager. To ensuring this was doable, however, required changing StateManager from tracking GroupNodeViewModels to tracking GroupTreeNodes. Something in this process broke the way that re-renders occur, and now I am facing persistent issues of:
    - Group numbers not updating when groups are added
    - Colors on entries not accurately reflecting the groups they are part of
    m-peeler committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    faca154 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ca5e69f View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Feature added: Right Click on entries to create group from selection

    Added functionality to allow users to right click to make a new group from the selection. Updated all group creation and group editing to use the CreateGroupAction class, extending SimpleCommand so it would work with the right-click menu.
    
    Getting this functionality extracted into an Action that could be called with the available states stored in stateManager required some pretty large changes and bug fixes related to synchronizing the various lists of active and selected entries.
    
    Additionally, fixed a bug where when new entries were dropped into a list, the displayed number of entries did not update.
    m-peeler committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    3a6037e View commit details
    Browse the repository at this point in the history
  2. Update CHANGELOG.md

    m-peeler committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    8dd474a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    12dedd4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2c87cda View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f3011ed View commit details
    Browse the repository at this point in the history
  6. Update CHANGELOG.md

    m-peeler committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    53f1544 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Update CHANGELOG.md

    Co-authored-by: Oliver Kopp <[email protected]>
    m-peeler and koppor authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    ec9b081 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aabb4a3 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'right-click-create-group' of https://github.com/m-peele…

    …r/jabref into right-click-create-group
    m-peeler committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    f654aba View commit details
    Browse the repository at this point in the history
  4. Fixed unnecessary module

    m-peeler committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    d772aaa View commit details
    Browse the repository at this point in the history
  5. Style & Bug Fixes

    Addressed failed tests and style guidelines
    m-peeler committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    d3e1f1e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e4ec775 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fd088d1 View commit details
    Browse the repository at this point in the history
  8. Added "Add Subgroup from Selection" to groups context menu.

    Fixed style issues, added new context menu option, fixed bug with update order when selecting a new active group after creating it
    m-peeler committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    e2ad784 View commit details
    Browse the repository at this point in the history
  9. Merge branch 'right-click-create-group' of https://github.com/m-peele…

    …r/jabref into right-click-create-group
    m-peeler committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    cf33b73 View commit details
    Browse the repository at this point in the history
  10. Fixed text comparison issue

    m-peeler committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    85d42b9 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Configuration menu
    Copy the full SHA
    ea49e46 View commit details
    Browse the repository at this point in the history
  2. Fixed bad bindings

    m-peeler committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    00de24b View commit details
    Browse the repository at this point in the history
  3. Removed accidential imports

    m-peeler committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    a1dfe75 View commit details
    Browse the repository at this point in the history
  4. Reverted Main Table Context-Menu change; Added 'include selected' che…

    …ckbox & preference
    
    Revered changes to context menu on the main table.
    
    Removed 'Current selection' radio button in `GroupDialog` and replaced with a 'Include currently selected entries' checkbox, liked both to a parameter in `GroupDialogViewModel` and a preference added to `GroupPreferences`.
    
    Edited preference menu to include this new preference.
    
    Streamlined `CreateGroupAction` to better fit these changes.
    
    Fixed bug where dragging new empty article entries into a new group wouldn't increment the group count.
    m-peeler committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    77f927b View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Configuration menu
    Copy the full SHA
    f80e515 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2024

  1. Configuration menu
    Copy the full SHA
    c5241f0 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'right-click-create-group' of https://github.com/m-peele…

    …r/jabref into right-click-create-group
    m-peeler committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    bba0522 View commit details
    Browse the repository at this point in the history
  3. Update src/main/java/org/jabref/gui/groups/GroupDialog.fxml

    Co-authored-by: Oliver Kopp <[email protected]>
    m-peeler and koppor authored Jul 13, 2024
    Configuration menu
    Copy the full SHA
    1912281 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4931eac View commit details
    Browse the repository at this point in the history
  5. Fixed imports

    m-peeler committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    f928a36 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Configuration menu
    Copy the full SHA
    93f2df5 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2024

  1. Configuration menu
    Copy the full SHA
    0367f7b View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. Configuration menu
    Copy the full SHA
    e87af8e View commit details
    Browse the repository at this point in the history