-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Right click create group #11476
base: main
Are you sure you want to change the base?
Right click create group #11476
Commits on Jul 5, 2024
-
Auto-Select Newly Created Group
When a new group is added, that group will automatically be selected and focused.
Configuration menu - View commit details
-
Copy full SHA for 910c857 - Browse repository at this point
Copy the full SHA 910c857View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbc0d7d - Browse repository at this point
Copy the full SHA cbc0d7dView commit details -
Implemented "Current selection" group option
Added new option to the "Group Options" in the GroupDialog to allow the creation of a group that contains the currently selected entries. If there are no entries selected, this option is disabled. If there is more than one entry selected, this option is selected by default.
Configuration menu - View commit details
-
Copy full SHA for f126974 - Browse repository at this point
Copy the full SHA f126974View commit details -
Addressed Style and Property Name Errors
Fixes failed unit test (keyValueShouldBeEqualForEnglishPropertiesMessages) and style test ( '(' is preceded with whitespace.)
Configuration menu - View commit details
-
Copy full SHA for e4c2281 - Browse repository at this point
Copy the full SHA e4c2281View commit details -
Created 'Create Group From Selection' action
Created the 'Create group from Seletion' item for the right-click menu and a new item on the menu. Began refactoring GroupDialogView, GroupDialogViewModel and GroupTreeViewModel to allow for creating a DialogView that automatically prioritizes 'Current selection'.
Configuration menu - View commit details
-
Copy full SHA for 9b4d2db - Browse repository at this point
Copy the full SHA 9b4d2dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9631067 - Browse repository at this point
Copy the full SHA 9631067View commit details -
Configuration menu - View commit details
-
Copy full SHA for d4222a7 - Browse repository at this point
Copy the full SHA d4222a7View commit details
Commits on Jul 7, 2024
-
Worked to implement right-click-to-make-group functionality
Attempted to implement right-click-to-add functionality to the codebase. This ran into several problems and a few Gordian knots which I was attempting, and failing, to untie. This work included using a standardized SimpleCommand to launch the GroupDialogView each time, and accessed the parameters for that through the StateManager. To ensuring this was doable, however, required changing StateManager from tracking GroupNodeViewModels to tracking GroupTreeNodes. Something in this process broke the way that re-renders occur, and now I am facing persistent issues of: - Group numbers not updating when groups are added - Colors on entries not accurately reflecting the groups they are part of
Configuration menu - View commit details
-
Copy full SHA for faca154 - Browse repository at this point
Copy the full SHA faca154View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca5e69f - Browse repository at this point
Copy the full SHA ca5e69fView commit details
Commits on Jul 9, 2024
-
Feature added: Right Click on entries to create group from selection
Added functionality to allow users to right click to make a new group from the selection. Updated all group creation and group editing to use the CreateGroupAction class, extending SimpleCommand so it would work with the right-click menu. Getting this functionality extracted into an Action that could be called with the available states stored in stateManager required some pretty large changes and bug fixes related to synchronizing the various lists of active and selected entries. Additionally, fixed a bug where when new entries were dropped into a list, the displayed number of entries did not update.
Configuration menu - View commit details
-
Copy full SHA for 3a6037e - Browse repository at this point
Copy the full SHA 3a6037eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8dd474a - Browse repository at this point
Copy the full SHA 8dd474aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12dedd4 - Browse repository at this point
Copy the full SHA 12dedd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c87cda - Browse repository at this point
Copy the full SHA 2c87cdaView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3011ed - Browse repository at this point
Copy the full SHA f3011edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 53f1544 - Browse repository at this point
Copy the full SHA 53f1544View commit details
Commits on Jul 10, 2024
-
Co-authored-by: Oliver Kopp <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ec9b081 - Browse repository at this point
Copy the full SHA ec9b081View commit details -
Configuration menu - View commit details
-
Copy full SHA for aabb4a3 - Browse repository at this point
Copy the full SHA aabb4a3View commit details -
Merge branch 'right-click-create-group' of https://github.com/m-peele…
…r/jabref into right-click-create-group
Configuration menu - View commit details
-
Copy full SHA for f654aba - Browse repository at this point
Copy the full SHA f654abaView commit details -
Configuration menu - View commit details
-
Copy full SHA for d772aaa - Browse repository at this point
Copy the full SHA d772aaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for d3e1f1e - Browse repository at this point
Copy the full SHA d3e1f1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e4ec775 - Browse repository at this point
Copy the full SHA e4ec775View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd088d1 - Browse repository at this point
Copy the full SHA fd088d1View commit details -
Added "Add Subgroup from Selection" to groups context menu.
Fixed style issues, added new context menu option, fixed bug with update order when selecting a new active group after creating it
Configuration menu - View commit details
-
Copy full SHA for e2ad784 - Browse repository at this point
Copy the full SHA e2ad784View commit details -
Merge branch 'right-click-create-group' of https://github.com/m-peele…
…r/jabref into right-click-create-group
Configuration menu - View commit details
-
Copy full SHA for cf33b73 - Browse repository at this point
Copy the full SHA cf33b73View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85d42b9 - Browse repository at this point
Copy the full SHA 85d42b9View commit details
Commits on Jul 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ea49e46 - Browse repository at this point
Copy the full SHA ea49e46View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00de24b - Browse repository at this point
Copy the full SHA 00de24bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a1dfe75 - Browse repository at this point
Copy the full SHA a1dfe75View commit details -
Reverted Main Table Context-Menu change; Added 'include selected' che…
…ckbox & preference Revered changes to context menu on the main table. Removed 'Current selection' radio button in `GroupDialog` and replaced with a 'Include currently selected entries' checkbox, liked both to a parameter in `GroupDialogViewModel` and a preference added to `GroupPreferences`. Edited preference menu to include this new preference. Streamlined `CreateGroupAction` to better fit these changes. Fixed bug where dragging new empty article entries into a new group wouldn't increment the group count.
Configuration menu - View commit details
-
Copy full SHA for 77f927b - Browse repository at this point
Copy the full SHA 77f927bView commit details
Commits on Jul 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f80e515 - Browse repository at this point
Copy the full SHA f80e515View commit details
Commits on Jul 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c5241f0 - Browse repository at this point
Copy the full SHA c5241f0View commit details -
Merge branch 'right-click-create-group' of https://github.com/m-peele…
…r/jabref into right-click-create-group
Configuration menu - View commit details
-
Copy full SHA for bba0522 - Browse repository at this point
Copy the full SHA bba0522View commit details -
Update src/main/java/org/jabref/gui/groups/GroupDialog.fxml
Co-authored-by: Oliver Kopp <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1912281 - Browse repository at this point
Copy the full SHA 1912281View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4931eac - Browse repository at this point
Copy the full SHA 4931eacView commit details -
Configuration menu - View commit details
-
Copy full SHA for f928a36 - Browse repository at this point
Copy the full SHA f928a36View commit details
Commits on Jul 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 93f2df5 - Browse repository at this point
Copy the full SHA 93f2df5View commit details
Commits on Aug 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0367f7b - Browse repository at this point
Copy the full SHA 0367f7bView commit details
Commits on Sep 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e87af8e - Browse repository at this point
Copy the full SHA e87af8eView commit details