Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a "view as BibTeX" option before importing an entry from the citation relation tab #11826

Closed
HoussemNasri opened this issue Sep 24, 2024 · 4 comments · Fixed by #11847
Closed

Add a "view as BibTeX" option before importing an entry from the citation relation tab #11826

HoussemNasri opened this issue Sep 24, 2024 · 4 comments · Fixed by #11847
Assignees
@JamseBonde007
Labels
entry-editor FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement

Comments

@HoussemNasri
Copy link
Member

HoussemNasri commented Sep 24, 2024 •
edited
Loading

When importing entries from the citation relation tab, a preview of entries to import is displayed, but it doesn't include all the information. It would be useful to click a button and display a dialog showing the full BibTeX of that entry.

image

Motivation

Could be useful for deciding whether to import a "duplicate" (record that may contain new data about an existing entry)

Refs #10869

Hint

  • Given that SourceTab exists this should be a fairly simple task.

Implementation options

  • Click a button, show a dialog with BibTeX
  • Expansion of the entry would be nice. You know accordion and "v"/">" button
@HoussemNasri HoussemNasri added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Sep 24, 2024
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Sep 24, 2024
@JamseBonde007
Copy link
Contributor

Hi! I'd love to give this issue a go. Could I please be assigned to it?

@Siedlerchr Siedlerchr added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Sep 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Welcome to the vibrant world of open-source development with JabRef!

Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

@ThiloteE ThiloteE moved this from Free to take to Reserved in Candidates for University Projects Sep 26, 2024
@ThiloteE ThiloteE moved this from Free to take to Reserved in Good First Issues Sep 26, 2024
@JamseBonde007
Copy link
Contributor

Is this a satisfactory solution?
img1
img2

@HoussemNasri
Copy link
Member Author

The UI looks good so far. Please open a draft pull request so we can begin reviewing the code changes.

The code doesn't need to be complete before the review starts. It's always better to catch potential issues early, as fixing them is easier before they compound.

JamseBonde007 pushed a commit to JamseBonde007/jabref that referenced this issue Sep 29, 2024
Add a "view as BibTeX" option before importing an entry from the cita…
c6b6275 
…tion relation tab JabRef#11826
JamseBonde007 pushed a commit to JamseBonde007/jabref that referenced this issue Sep 29, 2024
Add a "view as BibTeX" option before importing an entry from the cita…
a9b5423 
…tion relation tab JabRef#11826
@JamseBonde007 JamseBonde007 mentioned this issue Sep 29, 2024
Merged
6 tasks
JamseBonde007 pushed a commit to JamseBonde007/jabref that referenced this issue Sep 29, 2024
Correction of created errors JabRef#11826
bfe9dc9
JamseBonde007 pushed a commit to JamseBonde007/jabref that referenced this issue Sep 29, 2024
Fix problems JabRef#11826
e45203d
JamseBonde007 pushed a commit to JamseBonde007/jabref that referenced this issue Sep 29, 2024
Fix: Issuance of an instance JabRef#11826
cbf35b6
github-merge-queue bot pushed a commit that referenced this issue Oct 3, 2024
@JamseBonde007
Add a "view as BibTeX" option before importing an entry from the cita… (
d3c7e51 
#11847)

* Add a "view as BibTeX" option before importing an entry from the citation relation tab #11826

* Correction of created errors #11826

* Fix problems #11826

* Fix: Issuance of an instance  #11826

---------

Co-authored-by: Martin Mochnacký <[email protected]>
@github-project-automation github-project-automation bot moved this from Assigned to Done in Good First Issues Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamseBonde007 JamseBonde007

Labels
entry-editor FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement
Projects
Candidates for University Projects
Status: Done
Good First Issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a "view as BibTeX" option before importing an entry from the cita… JamseBonde007/jabref
3 participants
@Siedlerchr @HoussemNasri @JamseBonde007