Merge pull request #18 from Strafe153/strafe153/configure_await

Added ConfigureAwait(false)
JTOne123 · Apr 9, 2024 · da11f03 · da11f03
2 parents c89fef7 + 5b2d1f1
commit da11f03
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 7 deletions.
diff --git a/LiqPaySDK/LiqPay.SDK/LiqPayClient.cs b/LiqPaySDK/LiqPay.SDK/LiqPayClient.cs
@@ -54,7 +54,10 @@ private void CheckRequired()
         public async Task<LiqPayResponse> RequestAsync(string path, LiqPayRequest requestParams)
         {
             var data = PrepareRequestData(requestParams);
-            string response = await LiqPayClientHelper.PostAsync(LiqPayConsts.LiqpayApiUrl + path, data, Proxy);
+
+			string response = await LiqPayClientHelper
+                .PostAsync($"{LiqPayConsts.LiqpayApiUrl}{path}", data, Proxy)
+                .ConfigureAwait(false);
 
             return JsonConvert.DeserializeObject<LiqPayResponse>(response);
         }

diff --git a/LiqPaySDK/LiqPay.SDK/LiqPayClientHelper.cs b/LiqPaySDK/LiqPay.SDK/LiqPayClientHelper.cs
@@ -1,6 +1,5 @@
 using System.Collections.Generic;
 using System.IO;
-using System.Linq;
 using System.Net;
 using System.Net.Http;
 using System.Text;
@@ -12,7 +11,6 @@ public class LiqPayClientHelper
     {
         public static async Task<string> PostAsync(string url, Dictionary<string, string> data, WebProxy proxy = null)
         {
-            string urlParameters = null;
             var parameters = new List<string>();
             foreach (var item in data)
             {
@@ -22,7 +20,7 @@ public static async Task<string> PostAsync(string url, Dictionary<string, string
 
                 parameters.Add($"{item.Key}={utf8QueryValue}");
             }
-            urlParameters = string.Join("&", parameters);
+
             var httpClientHandler = new HttpClientHandler()
             {
                 Proxy = proxy
@@ -31,13 +29,19 @@ public static async Task<string> PostAsync(string url, Dictionary<string, string
             using (var httpClient = new HttpClient(httpClientHandler))
             {
                 var encoding = Encoding.GetEncoding(Encoding.UTF8.CodePage);
-                using (var responseMessage = await httpClient.PostAsync(url, new StringContent(urlParameters)))
+
+				var urlParameters = string.Join("&", parameters);
+                var stringContent = new StringContent(urlParameters);
+
+				using (var responseMessage = await httpClient.PostAsync(url, stringContent).ConfigureAwait(false))
                 {
                     responseMessage.EnsureSuccessStatusCode();
 
-                    using (var responseStream = await responseMessage.Content.ReadAsStreamAsync())
+                    using (var responseStream = await responseMessage.Content.ReadAsStreamAsync().ConfigureAwait(false))
                     using (var reader = new StreamReader(responseStream, encoding))
-                        return reader.ReadToEnd();
+                    {
+						return reader.ReadToEnd();
+					}
                 }
             }
         }