-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extent SourceTask for check and format tasks. #146
Conversation
Signed-off-by: Yahor Berdnikau <[email protected]>
If you are talking about this: @InputFiles
@SkipWhenEmpty
@PathSensitive(PathSensitivity.RELATIVE)
override fun getSource(): FileTree { return super.getSource() } I have to add it otherwise task becomes non-relocatable (not support caching). Original |
@Tapchicoma Yea, I know. That's why I was asking for feedback. Related: gradle/kotlin-dsl-samples#1026 Also, as pointed out by @eskatos, |
"${dir.path}/**/*.$extension" | ||
} | ||
}) | ||
javaExecSpec.args(getSource()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're sure this works? We only lint the sources we're supposed to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this actually returns paths to kotlin files, not directories passed to task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check added init {}
block that adds include filters to this source task. I assume internally it filters out all passed sources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Closes #85