fix BorrowAsync() timeInForce parameter (#231)

* fix BorrowAsync() timeInForce parameter * fixed test according to BorrowAsync() signature changes
JKorf · Oct 9, 2024 · 2c5bd40 · 2c5bd40
1 parent 53e0510
commit 2c5bd40
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/Kucoin.Net.UnitTests/RestRequestTests.cs b/Kucoin.Net.UnitTests/RestRequestTests.cs
@@ -103,7 +103,7 @@ public async Task ValidateSpotMarginCalls()
                 opts.OutputOriginalData = true;
             });
             var tester = new RestRequestValidator<KucoinRestClient>(client, "Endpoints/Spot/Margin", "https://api.kucoin.com", IsAuthenticated, "data", stjCompare: false);
-            await tester.ValidateAsync(client => client.SpotApi.Margin.BorrowAsync("ETH", Enums.TimeInForce.GoodTillCanceled, 1), "Borrow");
+            await tester.ValidateAsync(client => client.SpotApi.Margin.BorrowAsync("ETH", Enums.BorrowOrderType.FOK, 1), "Borrow");
             await tester.ValidateAsync(client => client.SpotApi.Margin.RepayAsync("ETH", 1), "Repay");
             await tester.ValidateAsync(client => client.SpotApi.Margin.GetBorrowHistoryAsync("ETH"), "GetBorrowHistory");
             await tester.ValidateAsync(client => client.SpotApi.Margin.GetRepayHistoryAsync("ETH"), "GetRepayHistory");

diff --git a/Kucoin.Net/Clients/SpotApi/KucoinRestClientSpotApiMargin.cs b/Kucoin.Net/Clients/SpotApi/KucoinRestClientSpotApiMargin.cs
@@ -77,7 +77,7 @@ public async Task<WebCallResult<IEnumerable<KucoinIsolatedRiskLimitConfig>>> Get
         /// <inheritdoc />
         public async Task<WebCallResult<KucoinNewBorrowOrder>> BorrowAsync(
             string asset,
-            TimeInForce timeInForce,
+            BorrowOrderType timeInForce,
             decimal quantity,
             bool? isIsolated = null,
             string? symbol = null,

diff --git a/Kucoin.Net/Interfaces/Clients/SpotApi/IKucoinRestClientSpotApiMargin.cs b/Kucoin.Net/Interfaces/Clients/SpotApi/IKucoinRestClientSpotApiMargin.cs
@@ -78,13 +78,13 @@ public interface IKucoinRestClientSpotApiMargin
         /// <param name="ct">Cancellation token</param>
         /// <returns>The id of the new order</returns>
         Task<WebCallResult<KucoinNewBorrowOrder>> BorrowAsync(
-           string asset,
-            TimeInForce timeInForce,
+            string asset,
+            BorrowOrderType timeInForce,
             decimal quantity,
             bool? isIsolated = null,
             string? symbol = null,
             bool? isHf = null,
-           CancellationToken ct = default);
+            CancellationToken ct = default);
 
         /// <summary>
         /// Repayment for previously borrowed asset