-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release/1.8.0: bug fix for compiling [email protected] with gfortran < 10 #477
release/1.8.0: bug fix for compiling [email protected] with gfortran < 10 #477
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Is the idea of not using if self.spec.satisfies("%gcc@:...")
to handle the case where we're using gfortran with clang or something like that?
Exactly. macOS uses apple-clang + gfortran, for example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
…pack package, remove from container configs (#1287) For release/1.8.0: Update submodule pointer for spack for the changes in JCSDA/spack#477. Remove g2 compiler flags in container configs, since these are now in the g2 package itself. Also include a bug fix to adjust the py-numpy version to match what is in configs/common/packages.yaml since yesterday (1.23.5).
For release/1.8.0: This PR is based on #476 (credits @RatkoVasic-NOAA), but narrowed down to one specific version of
g2
and forgfortran
earlier than version 10.Corresponding spack-stack PR: JCSDA/spack-stack#1287