Update ESMF from spack develop: add python dependency and extension (not for release/1.8.0) #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `+python` variant * `esmf` package installs Python bindings when `+python` is set Note: this does not inherit `PythonPackage`, which force an either/or choice between the Makefile and Pip builder: it instantiates a `PythonPipBuilder` as needed (when `+python` is set).
… feature/esmf_python_dependency_and_extension
climbfuji
changed the title
6 tasks
AlexanderRichert-NOAA
approved these changes
Sep 19, 2024
climbfuji
added a commit
to JCSDA/spack-stack
that referenced
this pull request
Sep 19, 2024
…actions cleanup section (not for release/1.8.0) (#1304) 1. Update the submodule pointer for the changes in JCSDA/spack#470 (Update ESMF from spack develop: add python dependency and extension) and enable the python variant in configs/common/packages.yaml. 2. Fix the cleanup section Github workflows. The find command returns a non-zero exit code if no files are found, causing the CI run to abort. See https://github.com/JCSDA/spack-stack/actions/runs/10942526277 for an example. Wrapping this find command in set +e / set -e section resolves this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picking the changes from PR https://github.com/spack/spack/pull/45504/commits for our
spack-stack-devbranch. With the exception of the "depends-on c/c++/fortran" changes (that our spack lib code doesn't support yet) and the disabling of OpenMP for macOS (only in our fork), the esmf package.py files are identical between spack develop and jcsda spack-stack-dev as of beginning of September 2024.See JCSDA/spack-stack#1304 for the associated spack-stack PR that enables the
pythonvariant in our spack-stack configs.