Add patch vfile_cassert.patch for [email protected] #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
srherbener
approved these changes
Aug 28, 2024
|
Thanks @srherbener for the quick review. I am planning to cherry-pick this and send it upstream afterwards. |
climbfuji
added a commit
to JCSDA/spack-stack
that referenced
this pull request
Aug 28, 2024
Update Atlantis site config: add oneapi setup and configure gcc compiler needed for intel and oneapi. Update Blackpearl site config: add aocc setup. Unrelated update of spack submodule pointer to include a bug fix for building [email protected] +ui (JCSDA/spack#469)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All in the title. Discovered and tested when building
ecflow+uion S4. There is already actsapi_cassert.patchfor 5.11.4 that fixes a similar bug in theBasedirectory.This needs to go into spack-stack-1.8.0.