Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ecmwf-atlas version 0.38 #453

Conversation

ericlingerfelt
Copy link
Collaborator

@ericlingerfelt ericlingerfelt commented Jul 30, 2024

Adding versions 0.38.0 and 0.38.1 for ecmwf-atlas.

@srherbener srherbener marked this pull request as ready for review August 7, 2024 17:06
@climbfuji
Copy link
Collaborator

For CI testing, see #453

@climbfuji climbfuji self-requested a review August 8, 2024 03:46
@climbfuji
Copy link
Collaborator

The corresponding spack develop PR was just merged; can you confirm that you cherry-picked the commit, i.e. same commit hash for our fork and spack develop?

@climbfuji climbfuji disabled auto-merge August 8, 2024 19:08
@srherbener
Copy link
Collaborator

@climbfuji good call! It looks like the commits don't match.
This PR: 481185b
Authoritative spack PR: 0b2e0a5

Not sure what went wrong. What's the recommended way to fix this? Thanks!

@climbfuji
Copy link
Collaborator

@climbfuji good call! It looks like the commits don't match. This PR: 481185b Authoritative spack PR: 0b2e0a5

Not sure what went wrong. What's the recommended way to fix this? Thanks!

Abandon this PR and cherry-pick the commit from spack develop probably?

@srherbener
Copy link
Collaborator

@climbfuji sounds good. I'll close this PR and start over.

@srherbener srherbener closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants