Remove release-jcsda version related code in fms package.py script #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: rem1776 <[email protected]> sync up with authoritative repo
srherbener
commented
Jul 12, 2024
| depends_on("ecbuild", type=("build"), when="@release-jcsda") | ||
| depends_on("jedi-cmake", type=("build"), when="@release-jcsda") | ||
| # *DH 20220602 | ||
| depends_on("llvm-openmp", when="+openmp %apple-clang", type=("build", "run")) |
There was a problem hiding this comment.
Note this line remains intact, it's just moved back to where it was in the authoritative repo version.
srherbener
requested review from
climbfuji,
ulmononian and
AlexanderRichert-NOAA
3 tasks
climbfuji
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: rem1776 [email protected]
This PR removes the release-jcsda related code from the fms package.py script and syncs up that script with the authoritative repo.