Switch to openmpi on macOS, update spack (merge spack authoritative updates as of 2022/04/04) #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feature/switch_to_openmpi_on_macos
…o feature/switch_to_openmpi_on_macos
…cos-apple-clang.yaml
climbfuji
commented
Apr 7, 2022
.gitmodules
Outdated
| @@ -2,5 +2,7 @@ | |||
| path = spack | |||
| #url = https://github.com/spack/spack | |||
| #branch = develop | |||
| url = https://github.com/NOAA-EMC/spack.git | |||
| branch = jcsda_emc_spack_stack | |||
| #url = https://github.com/NOAA-EMC/spack.git | |||
There was a problem hiding this comment.
For CI testing only, will be reverted prior to merging
climbfuji
commented
Apr 7, 2022
.gitmodules
Outdated
| @@ -2,5 +2,7 @@ | |||
| path = spack | |||
| #url = https://github.com/spack/spack | |||
| #branch = develop | |||
| url = https://github.com/NOAA-EMC/spack.git | |||
| branch = jcsda_emc_spack_stack | |||
| #url = https://github.com/NOAA-EMC/spack.git | |||
There was a problem hiding this comment.
For CI testing only, will be reverted prior to merging
…o feature/switch_to_openmpi_on_macos
climbfuji
changed the title
…o feature/switch_to_openmpi_on_macos
climbfuji
force-pushed
the
feature/switch_to_openmpi_on_macos
branch
from
a68b91b
to
21ce595
Compare
climbfuji
force-pushed
the
feature/switch_to_openmpi_on_macos
branch
5 times, most recently
from
7d42381
to
375a15f
Compare
climbfuji
force-pushed
the
feature/switch_to_openmpi_on_macos
branch
2 times, most recently
from
832b9d6
to
c42e55f
Compare
climbfuji
force-pushed
the
feature/switch_to_openmpi_on_macos
branch
4 times, most recently
from
4a4e2f9
to
342d34c
Compare
climbfuji
force-pushed
the
feature/switch_to_openmpi_on_macos
branch
3 times, most recently
from
3a5f152
to
bad06e5
Compare
climbfuji
force-pushed
the
feature/switch_to_openmpi_on_macos
branch
3 times, most recently
from
2522394
to
01825bc
Compare
climbfuji
force-pushed
the
feature/switch_to_openmpi_on_macos
branch
from
8b8c2d8
to
62114e9
Compare
|
@kgerheiser Ready for review. |
kgerheiser
reviewed
Apr 12, 2022
Comment on lines
+159
to
+176
| elif [[ "${{ inputs.mpi }}" == "mpich"* ]]; then | ||
| mpich_ver=${MPICH_VERSION} | ||
| echo "" >> ${SPACK_ENV}/spack.yaml | ||
| echo " packages:" >> ${SPACK_ENV}/spack.yaml | ||
| echo " mpich:" >> ${SPACK_ENV}/spack.yaml | ||
| echo " buildable: False" >> ${SPACK_ENV}/spack.yaml | ||
| echo " externals:" >> ${SPACK_ENV}/spack.yaml | ||
| echo " - spec: mpich@${mpich_ver}" >> ${SPACK_ENV}/spack.yaml | ||
| echo " prefix: $HOME/mpi" >> ${SPACK_ENV}/spack.yaml | ||
| elif [[ "${{ inputs.mpi }}" == "openmpi"* ]]; then | ||
| openmpi_ver=${OPENMPI_VERSION} | ||
| echo "" >> ${SPACK_ENV}/spack.yaml | ||
| echo " packages:" >> ${SPACK_ENV}/spack.yaml | ||
| echo " openmpi:" >> ${SPACK_ENV}/spack.yaml | ||
| echo " buildable: False" >> ${SPACK_ENV}/spack.yaml | ||
| echo " externals:" >> ${SPACK_ENV}/spack.yaml | ||
| echo " - spec: openmpi@${openmpi_ver}" >> ${SPACK_ENV}/spack.yaml | ||
| echo " prefix: $HOME/mpi" >> ${SPACK_ENV}/spack.yaml |
There was a problem hiding this comment.
Given the option of externally finding it, I would search for OpenMPI and MPICH instead of this.
There was a problem hiding this comment.
Good point. Now that I am using spack external find --all, it should be able to find it.
There was a problem hiding this comment.
I'll try this in the next set of PRs.
kgerheiser
reviewed
Apr 12, 2022
Comment on lines
+36
to
+37
| # upload-artifact does not allow filenames that contain '?' | ||
| rm -vf `find cache/source_cache -name '*\?*'` |
kgerheiser
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LD_LIBRARY_PATHinstead of using--dirtyflag for installingFixes #109
Fixes #28
Tested on macOS Monterey with llvm clang and mpich, and also with llvm clang and openmpi.
All CI tests passed (see https://github.com/NOAA-EMC/spack-stack/actions).