Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to draw shadow behind toasts #33

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

woelper
Copy link
Contributor

@woelper woelper commented Sep 27, 2024

This PR exposes the option to use a shadow on notifications in order to improve visibility. The shadow is optional.

@bircni
Copy link
Contributor

bircni commented Sep 27, 2024

Maybe also extend the examples to show the shadow

@woelper
Copy link
Contributor Author

woelper commented Sep 27, 2024

Maybe also extend the examples to show the shadow

I added a button to add shadows. Hope this works for you!

@bircni
Copy link
Contributor

bircni commented Sep 27, 2024

Could not spot any difference
with shadow:
image

without shadow:
image

@bircni
Copy link
Contributor

bircni commented Sep 27, 2024

I suggest changing the examples like this:
all.rs.txt

@woelper
Copy link
Contributor Author

woelper commented Sep 27, 2024

I suggest changing the examples like this: all.rs.txt

Done!

src/lib.rs Outdated Show resolved Hide resolved
@ItsEthra
Copy link
Owner

ItsEthra commented Oct 1, 2024

Also it says there are conflicts? you may need to rebase. and could you add a line to changelog I just created.

@woelper
Copy link
Contributor Author

woelper commented Oct 1, 2024

I have no idea how to resolve the conflicts in the fork to be honest... what I see from the gh tool and the web interface is not really helpful

@woelper
Copy link
Contributor Author

woelper commented Oct 1, 2024

I think I got it done using the web editor.

Copy link
Owner

@ItsEthra ItsEthra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ItsEthra ItsEthra merged commit 8c83456 into ItsEthra:master Oct 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants