Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to_duration signature #31

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Update to_duration signature #31

merged 1 commit into from
Sep 25, 2024

Conversation

edvorg
Copy link
Contributor

@edvorg edvorg commented Aug 28, 2024 •
edited
Loading

update to_duration to accept anything that is convertible into Option

@edvorg
Copy link
Contributor Author

edvorg commented Sep 15, 2024

@ItsEthra could you please have a look?

@ItsEthra
Copy link
Owner

Maybe a good idea would be to have the set_duration function accept impl Into<Option<Duration>> instead?

@edvorg
Copy link
Contributor Author

edvorg commented Sep 23, 2024

@ItsEthra sounds great! Updated the branch with suggested changes

ItsEthra
ItsEthra requested changes Sep 23, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@edvorg edvorg changed the title Update README.md Update to_duration signature Sep 24, 2024
@ItsEthra
Copy link
Owner

Thanks.

@ItsEthra ItsEthra merged commit 3fa49d1 into ItsEthra:master Sep 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsEthra ItsEthra ItsEthra requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edvorg @ItsEthra