conversations.members update #233
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Slack api has been updated so it doesn't always return the list of members for public channels. They're moving towards the conversations api.
This utilizes their
conversations.membersapi to get the updated members list when checking public channels. It caches the members for an hour so the load on the api isn't ridiculous. They don't have any batch support right now 😞 so looping through many channels can cause rate limiting 🙅♂️I've tried to keep with the existing structure but had to make some updates to properly pass along the api call to the
SlackChannelobject. This project is on java7 so I had to use a Callable instead of a CompletableFuture. This ended up requiring a decent amount of refactoring. So far, it's been working fine for us.