Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in mime type. #1399

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Fix typo in mime type. #1399

merged 1 commit into from
Oct 27, 2024

Conversation

ADmad
Copy link
Contributor

@ADmad ADmad commented Oct 27, 2024

No description provided.

@ADmad
Copy link
Contributor Author

ADmad commented Oct 27, 2024

I am a bit surprised this typo didn't cause any test failure. There does seem to be a test for it

$this->assertMediaType('image/avif', $result);

@olivervogel
Copy link
Member

Thank you. There is a test, but during the test run the type is taken directly from the encoded image data via mime_content_type() and is correct. The string parameter that was passed incorrectly is used to read the mime type from the instance of EncodedImage::class via without having to analyze the image data (with mime_content_type()), as the analysis functions require the fileinfo extension and I did not want to get into that dependency for this one method.

However, I will add tests for this case.

Thanks again.

@olivervogel olivervogel merged commit f712d68 into Intervention:develop Oct 27, 2024
8 checks passed
@olivervogel
Copy link
Member

Is fixed in 3.9.1.

@ADmad ADmad deleted the patch-1 branch October 27, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants