Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in cloner transparency #1388

Merged
merged 4 commits into from
Aug 11, 2024
Merged

Fix bug in cloner transparency #1388

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9564d59
Implement new method ColorInterface::isClear()
olivervogel Aug 5, 2024
cee93bd
Fix bug in Cloner::cloneEmpty()
olivervogel Aug 5, 2024
7a9bb78
Merge branch 'develop' into patch/cloner-transparency
olivervogel Aug 11, 2024
6a4607d
Adjust logic of cloner transparency application
olivervogel Aug 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Drivers/Gd/Cloner.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
namespace Intervention\Image\Drivers\Gd;

use GdImage;
use Intervention\Image\Colors\Rgb\Channels\Alpha;
use Intervention\Image\Colors\Rgb\Color;
use Intervention\Image\Exceptions\ColorException;
use Intervention\Image\Geometry\Rectangle;
Expand Down Expand Up @@ -67,6 +68,12 @@ public static function cloneEmpty(
imagealphablending($clone, true);
imagesavealpha($clone, true);

// set background image as transparent if alpha channel value if color is below .5
// comes into effect when the end format only supports binary transparency (like GIF)
if ($background->channel(Alpha::class)->value() < 128) {
imagecolortransparent($clone, $processor->colorToNative($background));
}

return $clone;
}

Expand Down