cardano-tracer: incorporate code review feedback

IntersectMBO · Jul 19, 2024 · 238d56a · 238d56a
1 parent dade1e6
commit 238d56a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 10 deletions.
diff --git a/cardano-tracer/src/Cardano/Tracer/Handlers/Metrics/Monitoring.hs b/cardano-tracer/src/Cardano/Tracer/Handlers/Metrics/Monitoring.hs
@@ -101,7 +101,7 @@ runMonitoringServer tracerEnv (endpoint@(Endpoint listHost listPort), monitorEP)
     , ttMonitoringType     = "list"
     }
   simpleHttpServe config do
-    route 
+    route
       [ ("/", renderEkg)
       ]
  where
@@ -117,7 +117,6 @@ runMonitoringServer tracerEnv (endpoint@(Endpoint listHost listPort), monitorEP)
   renderEkg :: Snap ()
   renderEkg = do
     nodes <- liftIO $ S.toList <$> readTVarIO teConnectedNodes
-
     -- HACK
     case nodes of
       [] ->
@@ -129,6 +128,10 @@ runMonitoringServer tracerEnv (endpoint@(Endpoint listHost listPort), monitorEP)
         ekgHtml monitorEP nodes
 
 {-# NOINLINE currentServerHack #-}
+-- | There is supposed to be one EKG server per port. The desired EKG
+-- server for the connected node gets restarted always on the same
+-- port. We limit functionality to only run one EKG server, this will
+-- be resolved in a future PR.
 currentServerHack :: CurrentEKGServer
 currentServerHack = unsafePerformIO newEmptyTMVarIO
 
@@ -140,7 +143,6 @@ ekgHtml (Endpoint monitorHost monitorPort) = \case
   [] ->
     toHtml @T.Text "ekgHtml: There are no connected nodes yet"
   connectedNodes -> do
-    li do toHtml @T.Text "OKAY"
     for_ connectedNodes \(NodeId anId) ->
       li do
         a ! href (fromString ("http://" <> monitorHost <> ":" <> show monitorPort))

diff --git a/cardano-tracer/src/Cardano/Tracer/Handlers/Notifications/Settings.hs b/cardano-tracer/src/Cardano/Tracer/Handlers/Notifications/Settings.hs
@@ -21,10 +21,6 @@ import qualified Data.ByteString as BS
 import qualified Data.ByteString.Lazy as LBS
 import qualified Data.Text as T
 
--- import           Crypto.Cipher.AES ()
--- import           Crypto.Cipher.Types ()
--- import           Crypto.Error ()
-
 readSavedEmailSettings :: Maybe FilePath -> IO EmailSettings
 readSavedEmailSettings rtvSD = do
   (pathToEmailSettings, _) <- getPathsToNotificationsSettings rtvSD

diff --git a/cardano-tracer/src/Cardano/Tracer/Utils.hs b/cardano-tracer/src/Cardano/Tracer/Utils.hs
@@ -127,9 +127,6 @@ showProblemIfAny verb action =
 logTrace :: String -> IO ()
 logTrace = traceWith stdoutTracer
 
--- logTrace :: String -> IO ()
--- logTrace = traceWith $ showTracing stdoutTracer
-
 connIdToNodeId :: Show addr => ConnectionId addr -> NodeId
 connIdToNodeId ConnectionId{remoteAddress} = NodeId preparedAddress
  where