32951 better icon for 'Add link' button

Intermesh · Aug 19, 2024 · 58ddddd · 58ddddd
1 parent f8bd787
commit 58ddddd
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 22 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 - Core: Attachments Custom field now shows files grid when configured as pictures
 - Tasks / support: accent class for grouping separator
 - Business: allow users with mayManageEmployees to create or destroy agreements
+- Core: more helpful / less generic "Add link" button icon
 
 13-08-2024: 6.8.64
 - Core: PHP 8.2 compatibility fix

diff --git a/www/go/core/views/extjs3/detail/AddButton.js b/www/go/core/views/extjs3/detail/AddButton.js
@@ -10,7 +10,7 @@
 
 go.detail.addButton = Ext.extend(Ext.Button, {
 	tooltip: t('Add'),
-	iconCls: 'ic-add',
+	iconCls: 'ic-add-link',
 	menu: [],
 	detailView: null,
 	documentTemplates: true,

diff --git a/www/modules/email/AddressContextMenu.js b/www/modules/email/AddressContextMenu.js
@@ -19,8 +19,6 @@ GO.email.AddressContextMenu = function(config)
 	}
 	config['shadow']='frame';
 	config['minWidth']=180;
-
-
 
 	this.composeButton = new Ext.menu.Item({
 		iconCls: 'btn-compose',

diff --git a/www/views/Extjs3/themes/Paper/src/_icons.scss b/www/views/Extjs3/themes/Paper/src/_icons.scss
@@ -57,18 +57,6 @@ i.icon {
 		@extend %icon;
 	}
 }
-// in dropdown menus
-/*.x-btn-text-icon, a.x-menu-item  {
-  //img { display:none;}
-  > span:before {
-    @extend %icon;
-    padding-right: dp(8);
-    position:absolute;
-    left: dp(24);
-    top: dp(4);
-  }
-}*/
-
 
 .x-tree-node-icon:before { // default icons
 	.x-tree-node-expanded & {content: 'folder_open'}
@@ -138,13 +126,6 @@ i {
 	}
 }
 
-/*
-define icons with:
-
-.entity.Note::before {
-	content: "description"
-}
-*/
 
 .x-tool::before, .ux-row-action-item {
 	@extend %icon;
@@ -372,6 +353,7 @@ $material-icons : (
 	add_box,
 	add_circle,
 	add_circle_outline,
+	add_link,
 	add_location,
 	add_shopping_cart,
 	add_to_photos,