Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
ExternalProject
,BUILD_BYPRODUCTS
is needed when using the ninja generator for ninja to correctly resolve dependenciesFrom CMP0058
The above mentions custom commands, but similar is true for
ExternalProject
, which is used to include some dependencieshttps://cmake.org/cmake/help/latest/module/ExternalProject.html#command:externalproject_add
I have tested the changes locally on a windows machine with one release and one debug build (note that ninja on windows needs to be used from the developer prompt when using MSVC from outside of Visual Studio)