Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger RuntimeError for when normalization is requested but not utilized #76

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Trigger RuntimeError for when normalization is requested but not utilized #76

wants to merge 2 commits into from

Commits on Dec 8, 2023

  1. refactor: making base task _compute_losses recognize norm 

    This change raises an error message for when the user has specified
normalization arguments, but none of them were used.

Signed-off-by: Lee, Kin Long Kelvin <[email protected]>
    @laserkelvin
    laserkelvin committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    55dc569 View commit details
    Browse the repository at this point in the history

  2. feat: include additional number of keys check 

    Also check that the number of used keys matches the number of keys
passed by the user.

Signed-off-by: Lee, Kin Long Kelvin <[email protected]>
    @laserkelvin
    laserkelvin committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    6e89424 View commit details
    Browse the repository at this point in the history