Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add version query param to JupyterLite URL #634

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Mar 14, 2023

This attempts to add more cache refreshing so the latest version of the notebook / JupyterLite deployment is retrieved.

However, testing locally, it did provide an updated notebook for me with Chrome, npm's http-server.

This attempts to add more cache refreshing so the latest version of the
notebook / JupyterLite deployment is retrieved.

However, testing locally, it did provide an updated notebook for me with
Chrome, npm's http-server.
@thewtex thewtex requested a review from oeway March 14, 2023 16:00
Copy link
Collaborator

@oeway oeway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, it didn't work for me, I think the caching is not in the browser, but it's in the jupyterlite storage layer (implemented via localForage I guess: https://jupyterlite.readthedocs.io/en/latest/howto/configure/storage.html).

With the Imjoy extension, we support load=raw github/gist url and open=1 but it seems failing for your file. The one worked is: https://jupyter.imjoy.io/lab/index.html?load=https://gist.github.com/oeway/391b4352ea57b5682366ce3dc2fa9174&open=1

With load= and open=, we make sure it loaded directly from the url, not the local storage, however, it doesn't work for the moment, strangely for this particular file.

I think the bug is coming from the file browser in jupyterlab, I just filed an issue here: jupyterlab/jupyterlab#14194

@thewtex thewtex marked this pull request as draft March 14, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants