-
-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Update libtiff's ITK module include paths #4974
BUG: Update libtiff's ITK module include paths #4974
Conversation
There is a separate issue in libtiff with "TIFFLIB_VERSION" not being correctly defined that is needed to get DCMTK to build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understands what goes on here, and not enough time to dive in.
Can you describe more what is this supposed to address?
I mean, is there a compile error, configure error, what? |
https://open.cdash.org/viewBuildError.php?buildid=10040501
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, under assumption that this fixes the issue.
This may be fine, but see #4953 (comment) for a more direct fix to that issue. |
DCMTK external project's configuration support forwarding ITK modules properties, not cmake target properties. Update libtiff's ITK module include properties to include the directory of the configuration files. Remove unneeded includes.
07a3dd8
to
36c668f
Compare
The update libtiff now has include that are specified as library properties and not full by ITK cmake variables.
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.