Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Update libtiff's ITK module include paths #4974

Merged

Conversation

blowekamp
Copy link
Member

The update libtiff now has include that are specified as library properties and not full by ITK cmake variables.

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

@github-actions github-actions bot added type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots area:ThirdParty Issues affecting the ThirdParty module labels Nov 21, 2024
@blowekamp
Copy link
Member Author

There is a separate issue in libtiff with "TIFFLIB_VERSION" not being correctly defined that is needed to get DCMTK to build.

Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understands what goes on here, and not enough time to dive in.

Can you describe more what is this supposed to address?

@dzenanz
Copy link
Member

dzenanz commented Nov 21, 2024

I mean, is there a compile error, configure error, what?

@blowekamp
Copy link
Member Author

I mean, is there a compile error, configure error, what?

https://open.cdash.org/viewBuildError.php?buildid=10040501

After merge of #4961, there are some build issues when DCMTK in enabled that I am investigating.
It looks like there are some library properties that are not being forwarded to the DCMTK External project:
https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/ThirdParty/TIFF/src/itktiff/libtiff/CMakeLists.txt#L125

Should these target properties be replaced in ITK's 3P module CMake code, or the DCMTK configuration be updated to extract these target properties and forward to DCMTK configuration.

https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/ThirdParty/DCMTK/CMakeLists.txt#L218

#4953 (comment)

Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, under assumption that this fixes the issue.

@bradking
Copy link
Member

This may be fine, but see #4953 (comment) for a more direct fix to that issue.

DCMTK external project's configuration support forwarding ITK modules
properties, not cmake target properties. Update libtiff's ITK module
include properties to include the directory of the configuration
files. Remove unneeded includes.
@bradking bradking changed the title BUG: DCMTK configuration support forwarding include properties BUG: Update libtiff's ITK module include paths Nov 22, 2024
@blowekamp blowekamp merged commit 27f1b1f into InsightSoftwareConsortium:master Nov 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ThirdParty Issues affecting the ThirdParty module type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants