Remove the need for Constraint::map()
callable
s to be pure
#8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Even though technically the map
callable
must be pure for theConstraint
to be pure, it's sometimes necessary to depend on an impure context to map the value. In the end this generatesInvalidArgument
by Psalm that doesn't help the program to be safer.Users then need to write
psalm-suppress
annotations in their code to fix this.This also prevents users to use third party packages that don't declare the purity of the code.
Solution
Remove the need for the
callable
s to be pure.