Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle password visibility #57

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Toggle password visibility #57

merged 2 commits into from
Feb 16, 2023

Conversation

IndrajeetPatil
Copy link
Owner

@IndrajeetPatil IndrajeetPatil commented Feb 16, 2023 •
edited
Loading

Closes #39

@IndrajeetPatil
Copy link
Owner Author

I haven't been able to get the styling correct, though.

Screenshot 2023-02-16 at 11 23 41

Screenshot 2023-02-16 at 11 23 33

TheHellem
TheHellem previously approved these changes Feb 16, 2023
View reviewed changes
Copy link
Collaborator

@TheHellem TheHellem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done

@IndrajeetPatil
Copy link
Owner Author

I am wondering if we should wait to merge this before the styling issue is fixed.

The fact that username and password input fields have different heights makes it look quite ugly.

@binghatch
Copy link
Collaborator

I adjusted the styling a bit and made the labels floating ones. Should be ready to commit!

@IndrajeetPatil
Copy link
Owner Author

Thanks!

@IndrajeetPatil IndrajeetPatil merged commit 8928359 into main Feb 16, 2023
@IndrajeetPatil IndrajeetPatil deleted the f39-toggle-password-visibility branch February 16, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheHellem TheHellem TheHellem left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow users to see their password when they enter it on login page
3 participants
@IndrajeetPatil @binghatch @TheHellem