Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design fixed #83

Merged
merged 5 commits into from
Feb 1, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions graphql/schema.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ type Building {
street_number: String,
street_name: String,
building_name: String,
display_name: String,
postcode: String,
ward: String,
conservation_area: String,
Expand Down
9 changes: 9 additions & 0 deletions helpers/createDataObj.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,19 @@
const createDataObj = (data) => {
return data.map((item, i) => {

let display_name;
if (item['Lower Case Building Name']) {
display_name = item['Lower Case Building Name']
} else {
display_name = item['Lower Case Street Name'];
}

return {
id: ++i,
street_number: item['Street Number'],
street_name: item['Lower Case Street Name'],
building_name: item['Lower Case Building Name'],
display_name: display_name,
postcode: item['Post Code'],
ward: item['Ward'],
conservation_area: item['Conservation Area'],
Expand Down
2 changes: 1 addition & 1 deletion middleware/graphql.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const grapqlSchema = buildSchema(
);

const getBuildings = async () => {
return await islington.find().sort({ id: 1 });
return await islington.find().sort({ display_name: 1 });
};

module.exports = graphqlHTTP({
Expand Down
1 change: 1 addition & 0 deletions models/islington.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ const islingtonSchema = new Schema({
street_number: String,
street_name: String,
building_name: String,
display_name: String,
postcode: String,
ward: String,
conservation_area: String,
Expand Down
6 changes: 4 additions & 2 deletions src/components/App.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class App extends Component {
this.setState({
building: building,
mapCenter: [building.longitude, building.latitude],
mapZoom: [15.5],
mapZoom: 15.5,
})
}

Expand All @@ -64,7 +64,8 @@ class App extends Component {
isHomePage = () => {
this.setState({
isHome: true,
isAbout: false
isAbout: false,
building: {}
});
}

Expand Down Expand Up @@ -145,6 +146,7 @@ const query = gql`
postcode
ward
building_name
display_name
conservation_area
date_built_actual
date_built_estimate
Expand Down
2 changes: 1 addition & 1 deletion src/components/BuildingDetails.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ class BuildingDetails extends Component {
</section>

<section>
<h4 className="ma0 f5 b"> Description </h4>
<h4 className="f5 b"> Description </h4>
<p>{description}</p>
</section>

Expand Down
8 changes: 4 additions & 4 deletions src/components/BuildingsList.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ class BuildingsList extends Component {
render() {
const { buildings = [], handleBuildingDetails } = this.props;
const buildingCards = buildings.map((building, i) => {
return <BuildingCard
key={i}
building={building}
handleBuildingDetails={handleBuildingDetails}
return <BuildingCard
key={i}
building={building}
handleBuildingDetails={handleBuildingDetails}
inputRef={this.props.inputRef}/>
})

Expand Down
6 changes: 3 additions & 3 deletions src/components/Footer.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,12 @@ const Footer = () => {
</section>

<section className="w-33-l pa2">
<div className="flex align-center justify-end">
<div className="flex items-center justify-center justify-end-l">
<div>
<img className="w4" alt="Partner: Historic England" src={historicEngland} />
<img className="w5" alt="Partner: Historic England" src={historicEngland} />
</div>
<div>
<img className="w4" alt="Partner: London Borough of Islington" src={islington} />
<img className="w5" alt="Partner: London Borough of Islington" src={islington} />
</div>
</div>
</section>
Expand Down
4 changes: 0 additions & 4 deletions src/components/Map.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@ class Map extends Component {

shouldComponentUpdate(nextProps, prevState) {
if (nextProps.building.significance && !prevState.selectedBuildingId) {
console.log(nextProps.building.id, 'building id nextprop')
console.log(nextProps.building.longitude, 'building longitude nextprop')
console.log(nextProps.building.latitude, 'building latitude nextprop')
this.selectedBuilding(nextProps.building.id);
let longitude = nextProps.building.longitude;
let latitude = nextProps.building.latitude;
Expand Down Expand Up @@ -76,7 +73,6 @@ class Map extends Component {
}

hoveringItem = (id) => {
console.log('hovering in hovering item')
this.setState({ hovering: !this.state.hovering, id } )
}

Expand Down
13 changes: 6 additions & 7 deletions src/components/Markers.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,28 +11,27 @@ const Markers = ({
buildings = [], handleBuildingDetails, hoveringItem, selectedBuilding,
goToViewport, hovering, id, selectedBuildingId
}) => {
const allMarkers = buildings.length > 0 && buildings.map((buildingObj, i) => {
let counter = ++i;

const allMarkers = buildings.length > 0 && buildings.map((buildingObj, i) => {
return (
<Marker
key={counter}
key={i}
longitude={buildingObj.longitude}
latitude={buildingObj.latitude}>

<div
onMouseEnter={(obj) => {
hoveringItem(counter);
hoveringItem(buildingObj.id);
}}
onClick={() => {
selectedBuilding(counter);
selectedBuilding(buildingObj.id);
handleBuildingDetails(buildingObj);
let longitude = buildingObj.longitude;
let latitude = buildingObj.latitude;
goToViewport({longitude, latitude});
}}
onTouchStart={() => {
selectedBuilding(counter);
selectedBuilding(buildingObj.id);
handleBuildingDetails(buildingObj);
let longitude = buildingObj.longitude;
let latitude = buildingObj.latitude;
Expand All @@ -44,7 +43,7 @@ const allMarkers = buildings.length > 0 && buildings.map((buildingObj, i) => {
>

{
(hovering && id === counter) || selectedBuildingId === counter ? <MarkerFilled /> : <MarkerEmpty />
(hovering && buildingObj.id === id) || buildingObj.id === selectedBuildingId ? <MarkerFilled /> : <MarkerEmpty />
}

</div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/Nav.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const Nav = ({ handleIsHomePage, handleIsAboutPage, isAbout }) => {
</div>

<p
className="ma0 primary pointer pt1 pl1 pr3" onClick = { () => { handleIsAboutPage()} }
className="ma0 primary pointer pt1 pl1 pr3 b underline f4-l" onClick = { () => { handleIsAboutPage()} }
> { isAbout ? 'Home' : 'About' } </p>
</nav>
);
Expand Down