Feature/correct word with punctuation is not searchable #8
+79
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
munir131
requested changes
Oct 2, 2024
tests/Entity/EntitySearchTest.php
Outdated
| $output = $search->baseResponse->original['entities']; | ||
|
|
||
| foreach ($output as $value) { | ||
| if(!(strpos($value->text,'green-ocean') || strpos($value->name,'green-ocean'))) |
There was a problem hiding this comment.
@brijm-improwised Test case is just checking happy path for -. You should check for @ , / also
…and then search for word and also add more option of punctuation to test
…into feature/correct-word-with-punctuation-is-not-searchable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5
Fixes Issue : word with punctuation should be searchable
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers