Update dockerfile/build.yml #96
Conversation
ghost
commented
Oct 3, 2023
•
ghost
commented
- Getting compiler.jar from https
|
|
||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v1 | ||
|
|
||
| - name: Login to GitHub | ||
| if: ${{ steps.docker-vars.outputs.has-docker-secret == 'true' }} | ||
| uses: docker/login-action@v1 | ||
| uses: docker/login-action@v2 | ||
| with: | ||
| registry: ghcr.io | ||
| username: ${{ github.repository_owner }} |
There was a problem hiding this comment.
According to the documentation of the login-action step, this should be
| username: ${{ github.repository_owner }} | |
| username: ${{ github.actor}} |
This would be my guess on how to fix it. The change from GTCR_PAT to GITHUB_TOKEN seems okay.
Also the up to date version of docker/login-action is v3
There was a problem hiding this comment.
I tested with these changes and got the following error in the Build and Push section
Error: buildx failed with: ERROR: failed to solve: failed to push ghcr.io/illarion-ev/illarion-server/base:pr-100: unexpected status from POST request to https://ghcr.io/v2/illarion-ev/illarion-server/base/blobs/uploads/: 403 Forbidden
seen here https://github.com/Illarion-eV/Illarion-Server/actions/runs/7427486427/job/20213407706?pr=100
Not too familiar with github or its workings, so not sure if I should click on "commit suggestion" on here to test things like this for PR reviews? As I wrote in #100 I was told early on to not directly edit things in Illarion-Content due to formatting so not sure if A. this applies to server side stuff too and B. if this applies to PR reviews like this, so I'm treading on the side of caution.
| with: | ||
| registry: ghcr.io | ||
| username: ${{ github.repository_owner }} | ||
| password: ${{ steps.docker-vars.outputs.docker-secret }} | ||
| password: ${{ steps.docker-vars.outputs.docker-secret }} |
There was a problem hiding this comment.
Mind the spaces 😛
| password: ${{ steps.docker-vars.outputs.docker-secret }} | |
| password: ${{ steps.docker-vars.outputs.docker-secret }} |
| @@ -13,7 +13,9 @@ jobs: | |||
| build: | |||
| name: Compile and Test | |||
| runs-on: ubuntu-latest | |||
|
|
|||
| permissions: | |||
There was a problem hiding this comment.
I tried testing it without the permissions: line just now and got the following error
You have an error in your yaml syntax on line 16
where it then got stuck and refused to finish the checks. So it seems like it might be necessary?
|
@Kerruan: I fixed the develop branch, so all the builds are running fine again. Once you rebase this pull-request and reduce the changes to what needs to be changed initially, everything should work fine. |
ghost
closed this by deleting the head repository
