Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force rules on boot despite crash #143

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

CurlyMoo
Copy link

@CurlyMoo CurlyMoo commented Nov 3, 2024

@stumbaumr
Copy link

stumbaumr commented Nov 3, 2024

Actions really need fixing now...

Like I stated here... #136 (comment)

@geduxas
Copy link

geduxas commented Nov 3, 2024

Actions really need fixing now...

Like I stated here... #136 (comment)

I fixed actions in my PR..

@CurlyMoo
Copy link
Author

CurlyMoo commented Nov 3, 2024

I fixed actions in my PR..

Are those fixes already accepted in the HeishaMon main branch?

@CurlyMoo
Copy link
Author

CurlyMoo commented Nov 3, 2024

@stumbaumr the action is fixed and build is done.

@stumbaumr
Copy link

I updated to your build and the /settings just hangs...
grafik

@CurlyMoo
Copy link
Author

CurlyMoo commented Nov 4, 2024

@stumbaumr can you check if the settings json does work?
http://192.168.178.151/getsettings

@stumbaumr
Copy link

stumbaumr commented Nov 4, 2024

There is indeed a bug in the JSON output...
grafik
..."hotspot":1,"listenonly":0,"force_rules"0,"listenmqtt":0,"mqtt_topic_listen":"master_panasonic_heat_pump",...

A : is missing after "force_rules"

@CurlyMoo
Copy link
Author

CurlyMoo commented Nov 4, 2024

Fixed

@stumbaumr
Copy link

Works and I activated the checkbox. So will have to see when there is another reboot...

@stumbaumr
Copy link

Seems to work properly. @IgorYbema , I think this can be merged.

@stumbaumr
Copy link

@McMagellan , have tried this as well? Is it working for you?

@McMagellan
Copy link

My experience is this:
I have been using HeishamonV5 with the original firmware 3.8 since it was delivered last week.
I couldn't start Heishamon because the necessary changes in the settings caused the settings-window to freeze.
I use an old laptop with Win10 and Firefox as the browser, which I used just as easily with Heishamon V4.
After I used Firefox in private mode instead of the normal browser mode, the settings could be loaded here without any problems.

I haven't installed any new firmware since then and this behavior still occurs.

@stumbaumr
Copy link

Is the PR merge coming? Or what is missing?

@stumbaumr
Copy link

@IgorYbema , could you kindly merge this too, please. I can not test newer builds without this…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants