Expose board type via mqtt #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamaradclimber
force-pushed
the
send_board_type
branch
4 times, most recently
from
a99869a to
116d0a8
Compare
|
@IgorYbema do you have feedback on this? |
|
Is much easier to change. The stats line is already different for the ESP8266 and ESP32 so you can insert a simpel identifier for the board type there. |
kamaradclimber
force-pushed
the
send_board_type
branch
from
116d0a8 to
5d8a635
Compare
|
Good feedback, thanks! I've pushed a new version, let me know if this sounds better. |
|
Better. I think we can skip the unknown and default to ESP32 if it is not ESP8266 (like most of the other code) |
kamaradclimber
force-pushed
the
send_board_type
branch
from
5d8a635 to
9216851
Compare
kamaradclimber
force-pushed
the
send_board_type
branch
from
9216851 to
3f1f4e9
Compare
|
Perfect, done! |
kamaradclimber
added a commit
to kamaradclimber/heishamon-homeassistant
that referenced
this pull request
Dec 25, 2024
This will allow to detect automatically the board type and thus the binaries to fetch Reference: IgorYbema/HeishaMon#140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help with kamaradclimber/heishamon-homeassistant#248 (comment)