Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add emoji support #104

Conversation

CodeThomnics
Copy link

No description provided.

@PureTryOut
Copy link

I don't think we should add emoji support to the package. Sending emoji's should really be handled by the keyboard of the operating system in use, it's not something every application should manually do.

Also please add some context to your PR's. Why do you want this feature? Please use the description field 😄

@CodeThomnics
Copy link
Author

I get you comment. I wanted to add emoji support for different platforms and able to send them everywhere and correctly rendered. I will add this to the description next time and motivate my reason. Thanks for the feedback

@PureTryOut
Copy link

What are those different platforms though? At least Linux (KDE Plasma that is, pretty sure GNOME too) and macOS have their own emoji selectors. So do Android and iOS. I'm unsure about Windows but I find it hard to believe they don't have something either.

With that you have basically all platforms covered (excluding web, those use the same emoji pickers as all the other platforms ofc).

@CodeThomnics
Copy link
Author

Well, i get this result on KDE with the emoji selector. I don't know if it is a good result. It's different from what the emoji selector shows
image

@PureTryOut
Copy link

That's a system problem, you're missing the right font. I think font-noto-emoji (check your distribution for the right package name) should do it but you'll have to verify it for yourself.

@CodeThomnics
Copy link
Author

i have it installed but it doesn't fix it. I think flutter doesn't render it

@CodeThomnics CodeThomnics closed this by deleting the head repository Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants