Bugfix/mon 13349 Trendsgraph on wkhtmltopdf #318
+311
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replace the trends graph generated using javascript.. Created a new function using php instead of calling the javascript function to generated the graph. Using javscript on generating trends graph causes it not to be rendered when saving the report as pdf. This is part of MON-13349 Signed-off-by: Eunice Remoquillo <[email protected]>
This commit displays bar details on mouse hover. This is part of MON-13349 Signed-off-by: Eunice Remoquillo <[email protected]>
This commit fixes bar positions on the graph when generating a pdf. Added display prefixes for other vendors. Signed-off-by: Eunice Remoquillo <[email protected]>
This commit fixes the positions of lines and y-labels. Signed-off-by: Eunice Remoquillo <[email protected]>
Added datetime details on hover. And changed the format used for datetime to remove leading zeroes. Signed-off-by: Eunice Remoquillo <[email protected]>
This commit changes the rgb component to hexadecimal color code. Signed-off-by: Eunice Remoquillo <[email protected]>
This reverts commit 0f0305f.
jdumalaonITRS
requested changes
Apr 23, 2024
This commit displays the trend scale for trends bar with a short duration. When scaling, the short bar is changed to black then creates a smaller bar above it. Colored bars must display details when hovered. Unused css file was removed. Indentions were fixed. And necessary variables were created. Signed-off-by: Eunice Remoquillo <[email protected]>
Adjusted the min-width to 10px to avoid overflow in the scaled row.
Objects with white color automatically disregards style set to transparent.
This commit replace the trends graph generated using javascript.. Created a new function using php instead of calling the javascript function to generated the graph. Using javscript on generating trends graph causes it not to be rendered when saving the report as pdf. This is part of MON-13349 Signed-off-by: Eunice Remoquillo <[email protected]>
This commit displays bar details on mouse hover. This is part of MON-13349 Signed-off-by: Eunice Remoquillo <[email protected]>
This commit fixes bar positions on the graph when generating a pdf. Added display prefixes for other vendors. Signed-off-by: Eunice Remoquillo <[email protected]>
This commit fixes the positions of lines and y-labels. Signed-off-by: Eunice Remoquillo <[email protected]>
Added datetime details on hover. And changed the format used for datetime to remove leading zeroes. Signed-off-by: Eunice Remoquillo <[email protected]>
This commit changes the rgb component to hexadecimal color code. Signed-off-by: Eunice Remoquillo <[email protected]>
This reverts commit 0f0305f.
This commit displays the trend scale for trends bar with a short duration. When scaling, the short bar is changed to black then creates a smaller bar above it. Colored bars must display details when hovered. Unused css file was removed. Indentions were fixed. And necessary variables were created. Signed-off-by: Eunice Remoquillo <[email protected]>
Adjusted the min-width to 10px to avoid overflow in the scaled row.
Objects with white color automatically disregards style set to transparent.
euniceremoquillo
force-pushed
the
bugfix/MON-13349-Trendsgraph-on-Wkhtmltopdf
branch
from
dcee7e4 to
31e523a
Compare
…/github.com/ITRS-Group/monitor-ninja into bugfix/MON-13349-Trendsgraph-on-Wkhtmltopdf
Adjusted the size of displayed block so it captures the whole trend block line.
This commit added checks on listed host from the generated graph. This also checks if there will be a displayed information upon hovering a bar from the graph.
This reverts commit ee65047.
This commit improves graph readability for short bars.
This commit fixes the accuracy of calculated bar length.
This commit handles the number of allowable items to display on the graph. Since displaying graphs should be displayed per percentage, displaying a hundred of items would be the threshold. Signed-off-by: Eunice Remoquillo <[email protected]>
This reverts commit b72ae46.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendering trends graph on the browser has no issue, however the latest version of wkhtmltopdf cannot render the graph when generating pdf.
This replace tgraph.js as a php function in a new view file. This commit resolves the issue on displaying the trends graph on the generated pdf file.
This is resolves MON-13349
Signed-off-by: Eunice Remoquillo [email protected]