Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed show logs from all nodes checkbox #315

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

euniceremoquillo
Copy link
Contributor

This commit removes the show all logs from nodes checkbox on the gui. The show logs from all nodes function should still work via cmd line.

This resolves MON-13363.

Signed-off-by: Eunice Remoquillo [email protected]

This commit removes the show all logs from
nodes checkbox on the gui.
The show logs from all nodes function should
still work via cmd line.

Signed-off-by: Eunice Remoquillo <[email protected]>
@jdumalaonITRS
Copy link
Contributor

Based on Ninja code,
there seems to be already a methid to determine if a user has writes to access show log via:
$this->_verify_access('ninja.showlog:read.showlog');

e.g.
monitor-ninja/modules/monitoring/controllers/showlog.php:102

I think we need to explore ths some more and check how to add similar functionality to show log for all nodes.

@euniceremoquillo
Copy link
Contributor Author

Based on Ninja code, there seems to be already a methid to determine if a user has writes to access show log via: $this->_verify_access('ninja.showlog:read.showlog');

e.g. monitor-ninja/modules/monitoring/controllers/showlog.php:102

I think we need to explore ths some more and check how to add similar functionality to show log for all nodes.

Will be taking a look at this one. The UI config for this can be added to the Process Information Page (image attached in the ticket description)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants