Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 [Frontend] UX: Create Study from Template #6706

Merged
merged 26 commits into from
Nov 14, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 12, 2024

What do these changes do?

Currently, when creating a Study from a Template:

  1. waiting: there is a view showing that the data is being copied (long running task)
  2. user input required: once copied, the study is created and the the Study Options (rename, select credit account, tiers) are shown to the user
  3. waiting: then the study opens

In order to improve the UX, in this PR, instead of waiting, then user input and then waiting again, the steps 1 and and 2 are switched, so that user's input is required right after opening the template and then the data is copied and finally the brand new study opened.

Before:
Before

After:
After

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Nov 12, 2024
@odeimaiz odeimaiz added this to the Event Horizon milestone Nov 12, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) UX_improvements UX Feedback during frontend testing process labels Nov 12, 2024
@odeimaiz odeimaiz marked this pull request as ready for review November 12, 2024 14:32
@odeimaiz odeimaiz enabled auto-merge (squash) November 12, 2024 14:39
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: should we not adapt the backend to take as input these parameters that you are caching, while it is coping the study?

@odeimaiz
Copy link
Member Author

Question: should we not adapt the backend to take as input these parameters that you are caching, while it is coping the study?

That could also be a solution.

Yet another solution would be that the study is created right away (so I can play with its metadata) and then the data copy starts...

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz enabled auto-merge (squash) November 13, 2024 15:12
Copy link

sonarcloud bot commented Nov 14, 2024

@odeimaiz odeimaiz merged commit 17f486e into ITISFoundation:master Nov 14, 2024
51 checks passed
@odeimaiz odeimaiz deleted the ux/create-from-template branch November 14, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature UX_improvements UX Feedback during frontend testing process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants