-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Adding tracing to agent
and dynamic-sidecar
(🏗️ DEVOPS)
#6691
🎨 Adding tracing to agent
and dynamic-sidecar
(🏗️ DEVOPS)
#6691
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6691 +/- ##
===========================================
- Coverage 87.46% 65.32% -22.14%
===========================================
Files 1533 633 -900
Lines 61179 31482 -29697
Branches 2119 265 -1854
===========================================
- Hits 53509 20566 -32943
- Misses 7344 10855 +3511
+ Partials 326 61 -265
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
…-opentelemetry-to-missing-services
…-opentelemetry-to-missing-services
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, thanks a lot!
agent
and dynamic-sidecar
agent
and dynamic-sidecar
(🏗️ DEVOPS)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait for OPS PR.
@mrnicegyu11 is preparing OPS changes
this should do the trick @GitHK @YuryHrytsuk ITISFoundation/osparc-ops-environments#872 |
* wip * Add csi-s3 and have portainer use it * Change request @Hrytsuk 1GB max portainer volume size * Sister PR6691 --------- Co-authored-by: Dustin Kaiser <[email protected]>
Thanks a lot, will go ahead and merge now |
Quality Gate passedIssues Measures |
What do these changes do?
agent
servicedynamic-sidecar
this is inherited from thedirector-v2
tracing options. If tracing is enabled on director-v2 it will also enable it on all dynamic-sidecarsDEVOPS Tasks
Related issue/s
How to test
Dev-ops checklist