Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added code for missing arifacts in Manage account #168

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Added code for missing arifacts in Manage account #168

wants to merge 1 commit into from

Conversation

yashshah15
Copy link

It seems like the dashboard object was not getting claimed artifacts. I have made a separate backend API call for fetching user artifacts. This pull request is for the issue #154

@carboxylman
Copy link
Contributor

Thanks Yash. What we want to do is not make an extra call, but to use the same mapped state data as pages/myartifacts.js already does. This way, if we already have fetched the artifacts, we don't have to fetch them a second time...

@yashshah15
Copy link
Author

Thanks Yash. What we want to do is not make an extra call, but to use the same mapped state data as pages/myartifacts.js already does. This way, if we already have fetched the artifacts, we don't have to fetch them a second time...
I tried fetching the artifacts in the way you mentioned but, the owned_artifacts list is empty in index.Vue of profile page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carboxylman carboxylman Awaiting requested review from carboxylman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yashshah15 @carboxylman