11044 edit facet bug #11052
Open
11044 edit facet bug #11052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sekmiller
added
FY25 Sprint 11
|
Haven't tried to review - would it possible to also add a db constraint to avoid more than one entry per datasetfieldtype_id + dataverse_id combo? |
This comment has been minimized.
This comment has been minimized.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
|
|
||
| } | ||
There was a problem hiding this comment.
🚫 [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
File contains tab characters (this is the first instance).
|
@qqmyers I thought about adding a DB constraint, but I was worried that if it was violated it would fail badly - or at least in a way that would be difficult for the end user to understand/fix. |
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes an issue where the facets would be added multiple times on Edit Dataverse
Which issue(s) this PR closes:
Special notes for your reviewer:
The issue was that while the existing facets were deleted in the DB, they were left as part of the Dataverse being edited so when the dataverse is saved the facets were re-created. Similar situation for field input levels.
Suggestions on how to test this: Edit Dataverse via api and UI and verify that the facets and dataset field input levels are being saved correctly with no doubling of entries. (see original ticket for example of failure state.)
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: No
Additional documentation: None - fixing documented behavior