Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev #222

Merged
merged 209 commits into from
Oct 23, 2024
Merged

Dev #222

merged 209 commits into from
Oct 23, 2024

Conversation

sergeiandreyev
Copy link
Contributor

Merge dev to main

stafverhaegen-chipflow and others added 30 commits May 27, 2024 14:34
@stafverhaegen-chipflow
Some updates on top of #121
86426af 
* Remove labels on ESD diodes so they are now recognized as regular
  d(p)antenna diodes
* Increase width to minimum 0.48µm to account for new rule not yet in
  DRC check.

Signed-off-by: Staf Verhaegen <[email protected]>
@KrzysztofHerman
Update README.md
daa7b46 
OpenROAD, OpenROAD flow scripts, Qucs-S added as supported EDA tools.

Signed-off-by: Krzysztof Herman <[email protected]>
@KrzysztofHerman
Merge branch 'dev' of ssh://github.com/KrzysztofHerman/IHP-Open-PDK i…
71af111 
…nto dev

Merging synced dev  branch from own forc to local repo
Klayout PyCell integration
04d05f4 
-added partial implementation of class Pin from PyCell API
-added partial implementation of class Term from PyCell API
-added support for pins/terminals
-added support for XOR geometric transformation
-added support for text alignment/orientation
-fixed dbLayerXorList from geometry.py
-added support of npn13G2L and npn13G2V
-extended documentation

Signed-off-by: ThomasZecha <[email protected]>
@KrzysztofHerman
Merge pull request #128 from ThomasZecha/dev
6db04d6 
Klayout PyCell integration
@KrzysztofHerman
Merge pull request #122 from ChipFlow/io_fix2
2a6fbb2 
Some updates on top of #121
@lild4d4
lvs-symbol
b1a309b 
Signed-off-by: Daniel Arevalos <[email protected]>
@KrzysztofHerman
lv symbols modified for lvs, @spiceprofix added
10ab9d5 
Signed-off-by: KrzysztofHerman <[email protected]>
@KrzysztofHerman
Layout rule manual updated
bc09d94 
Signed-off-by: KrzysztofHerman <[email protected]>
@KrzysztofHerman
Merge branch 'IHP-GmbH:dev' into dev
c399607
@KrzysztofHerman
Merge pull request #129 from KrzysztofHerman/dev
cf217e1 
Layout rule manual update
@FaragElsayed2
Removing NO DRC filter for LVS runset for all layers
7ceccaa 
Signed-off-by: FaragElsayed2 <[email protected]>
@FaragElsayed2
Merge branch 'dev' of https://github.com/mabrains/IHP-Open-PDK into l…
e8ce17e 
…vs_dev2
@FaragElsayed2
Merge branch 'dev' of https://github.com/mabrains/IHP-Open-PDK into l…
4cba5f3 
…vs_dev2
@atorkmabrains
Merge pull request #15 from mabrains/lvs_dev2
c628596 
Removing NO DRC filter for LVS runset for all layers
@KrzysztofHerman
Merge pull request #131 from mabrains/dev
3f24b92 
Remove NO_DRC filtering
@KrzysztofHerman
@spiceprefix added for mos devices and diodes, RF symbols added for H…
a46968e 
…V mosfets

Signed-off-by: KrzysztofHerman <[email protected]>
@KrzysztofHerman
Merge branch 'mos-prefix' into dev
cd1f216
@KrzysztofHerman
Merge branch 'dev' of ssh://github.com/KrzysztofHerman/IHP-Open-PDK i…
1f44dda 
…nto dev
@KrzysztofHerman
DRC checks for xschem added in xschemrc (mosfets, hbt, diode, res, mi…
25f01bc 
…m), symbols modified, some testcases modified

Signed-off-by: KrzysztofHerman <[email protected]>
Klayout PyCell integration
90ec2eb 
-added PyCell parameter type bool
-added partial implementation for PyCell API class Net
-added partial implementation for PyCell API class Path
-added partial implementation for PyCell API class ShapeFilter
-added support for Net's
-added generic registering of IHP PyCell's in Klayout
-added support for inductor2, inductor2_sc, inductor2_sp, inductor3,
 inductor3_sc and inductor3_sp
-updated documentation

Signed-off-by: ThomasZecha <[email protected]>
Klayout PyCell integration
d177f46 
-fixed merge-error

Signed-off-by: ThomasZecha <[email protected]>
@sergeiandreyev
Merge pull request #133 from ThomasZecha/dev
d583d5d 
Klayout PyCell integration
@lild4d4
hv-mos pcell integration
674aac6 
Signed-off-by: Daniel Arevalos <[email protected]>
@lild4d4
Merge branch 'hv-mos' into dev
acdb0fc
@lild4d4
hv added to init
00ee762
@sergeiandreyev
KLayout Pycells: updated 'Ae' text string in npn13G2* cells to be con…
9f1b0c0 
…sistent w/ internal implementation

Signed-off-by: Sergei Andreev <[email protected]>
@lild4d4
fixing commit
69a8ec8
@lild4d4
Merge branch 'IHP-GmbH:dev' into dev
eb437c2
@lild4d4
fixing commit
11d18a7
dnltz and others added 15 commits September 30, 2024 14:13
@dnltz
iho-sg13g2: libs.ref: sg13g2_io: verilog: Fix specify syntax
2a87bd8 
The input and output definition in the Verilog specify block
were positioned in the wrong order (output to input). Change
and also implement the tri-state better.

Signed-off-by: Daniel Schultz <[email protected]>
@sergeiandreyev
Qucs-S install script: added Python shebang line
3bde396 
Signed-off-by: Sergei Andreev <[email protected]>
@sergeiandreyev
Merge pull request #215 from dnltz/WIP/dnltz/fix-io-specify
4dc9d2e 
iho-sg13g2: libs.ref: sg13g2_io: verilog: Fix specify syntax
@sergeiandreyev
pnpMPA: fixed pin order in model, updated xschem symbol and testbench (…
3a5155f 
…#37)

Signed-off-by: Sergei Andreev <[email protected]>
@sergeiandreyev
xschem install script: added Python shebang line
065060b 
Signed-off-by: Sergei Andreev <[email protected]>
@sergeiandreyev
Update ISSUE_TEMPLATE.md
538e111 
- removed explicit env items, user should put his own related settings

Signed-off-by: Sergei Andreev <[email protected]>
@KrzysztofHerman
pyprocessor switched to IHP fork and added to the dev branch
1ff0c76 
Signed-off-by: KrzysztofHerman <[email protected]>
@KrzysztofHerman
.spiceinit hotfix
4107d18 
Signed-off-by: KrzysztofHerman <[email protected]>
@sergeiandreyev
added CHANGELOG
4bf8f9f 
Signed-off-by: Sergei Andreev <[email protected]>
@KrzysztofHerman
Merge branch 'IHP-GmbH:dev' into dev
8d7a19b
@KrzysztofHerman
USE ANALOG changed to USE SIGNAL
1e14418 
Signed-off-by: KrzysztofHerman <[email protected]>
@KrzysztofHerman
Merge pull request #217 from KrzysztofHerman/dev
544dada 
.SPICEINIT hotfix
@sergeiandreyev
Update CHANGELOG.md
98f0891 
added 1e14418 commit

Signed-off-by: Sergei Andreev <[email protected]>
@sergeiandreyev
restoring lvs_options.yml
1644a8e 
Signed-off-by: Sergei Andreev <[email protected]>
@sergeiandreyev
.gitignore: included lvs_options.yml
d3b389d 
Signed-off-by: Sergei Andreev <[email protected]>
@dnltz
Copy link
Contributor

dnltz commented Oct 18, 2024

@sergeiandreyev looks like the DCO plugin is not configured correctly and doesn't run on pull requests to dev. Missing SOBs should be caught earlier.

dnltz and others added 4 commits October 18, 2024 10:29
@dnltz
ihp-sg13g2: libs.tech: klayout: python: Move getProcessNames()
c27deca 
This function has a hard depdendency to 'psutil' but is only required
when IHP_PYCELL_LIB_PRINT_PROCESS_TREE is set. Move 'getProcessNames'
inside the if block to allow using this PDK without 'psutil' installed.

Signed-off-by: Daniel Schultz <[email protected]>
@KrzysztofHerman
Merge pull request #227 from dnltz/WIP/dnltz/fix-psutil
7c983da 
ihp-sg13g2: libs.tech: klayout: python: Move getProcessNames()
@KrzysztofHerman
Revert "ihp-sg13g2: libs.tech: klayout: python: Move getProcessNames()"
91d2e9e
@KrzysztofHerman
Merge pull request #228 from IHP-GmbH/revert-227-WIP/dnltz/fix-psutil
eddab56 
Revert "ihp-sg13g2: libs.tech: klayout: python: Move getProcessNames()"
@sergeiandreyev
Copy link
Contributor Author

@dnltz , do you mean as example these 'Merge' PRs?
image
these do not have have DCO signed

@dnltz
Copy link
Contributor

dnltz commented Oct 21, 2024

@sergeiandreyev no, they are fine. I mean this action (https://github.com/IHP-GmbH/IHP-Open-PDK/pull/222/checks?check_run_id=31736802611) only gets triggered when merging to the default branch. It doesn't check pull requests to dev, which is used as intermediate branch.

For example, this commit has no signed-off-by: 00ee762

@dnltz
Copy link
Contributor

dnltz commented Oct 21, 2024

@sergeiandreyev everything fine! Just saw my pull request (#172) failed not with missing signed-off-by!

@sergeiandreyev
Copy link
Contributor Author

ok, good!
still I don't understand for now why the merge PRs have DCO violations (see my previous comment)

@sergeiandreyev
Copy link
Contributor Author

it seems to be limited only to the commits from Oct 18..

@dnltz
Copy link
Contributor

dnltz commented Oct 21, 2024

it seems to be limited only to the commits from Oct 18..

I think so too.

I would just follow the DCO instructions:

To add your Signed-off-by line to every commit in this branch:

- Ensure you have a local copy of your branch by [checking out the pull request locally via command line](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally).
- In your local branch, run: git rebase HEAD~208 --signoff
- Force push your changes to overwrite the branch: git push --force-with-lease origin dev

@sergeiandreyev
KLayout LVS: moved 'require win32ole' inside the conditional Windows …
20d2118 
…branch in sg13g2_full.lylvs

Signed-off-by: Sergei Andreev <[email protected]>
@KrzysztofHerman KrzysztofHerman merged commit 035037f into main Oct 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrzysztofHerman KrzysztofHerman KrzysztofHerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.