-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add first version of script computing the aggregated stats for a release #19
Conversation
The script seems to be adding newlines after every run, but not taking these into account when the script is run again on the same file. This results in ampty lines.
|
The column of Experiments? seems to being missed by this script, is that intentional ?
The first two rows above are from the previous releases.tsv, the two new lines were added by this script. |
Yes we are now omitting |
The last commit in the script fixes the empty line issue by passing a csv file to the
should add a line to |
Co-authored-by: Mark Carroll <[email protected]>
scripts/releases.py
Outdated
parser.add_argument("--format", default="tsv", help=( | ||
"Output format, includes 'string', 'csv', 'tsv' (default), and " | ||
"'json'. " | ||
"'tsv' can be appended to the IDR studies.csv file with no further " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line 80 of the script, which contains the verbose help output, seems misleading. A tsv
output can be appended to a studies.csv
file... ? Should that not be releases.tsv
instead ?
Two suggestions for the help text, otherwise works as described, the empty lines are not produced anymore and the simplification of the script commands (no necessity to specify a path to |
Co-authored-by: pwalczysko <[email protected]>
Thanks @pwalczysko. Pushed an extra commit to clarify the description of the output and include the new workflow. Once this is signed off, the only remaining step might be to update the Submission workflow accordingly. @dominikl I assume I should be able to close IDR/idr.openmicroscopy.org#92 with a link to the various PRs or do you know of any remaining to do? |
Co-authored-by: pwalczysko <[email protected]>
Co-authored-by: pwalczysko <[email protected]>
Consumed by IDR/idr.openmicroscopy.org#94 /cc @pwalczysko