Enable unicode characters for TS channel and Arma server names

[tbeswick96]

When merged this pull request will:

• Allow unicode characters in TeamSpeak channel names and Arma server names
• Change relevant TS3 methods for channel switching to use wstring instead of string
• Add 2 conversion methods to convert between string and wstring
• Stop the TextMessage __isascii check from running only for setTs3ChannelDetails procedure
• Fix Non-ASCII characters break channel switching #579
• Tested locally using a TeamSpeak channel name containing Grę and a local Arma MP instance with server name Grę. Channel switching works as expected. All other functionality seems unaffected (Could use a smoke test if anyone is interested in building and testing)

---

Notes:

• The data coming from arma comes in as char*. This gets interpreted as ASCII, and the majority of data passed around inside ACRE is ASCII.
• The unicode conversion for channel switching only happens in the RPC function setTs3ChannelDetails. This means data is sent into it in the "wrong" format, is converted and used accordingly, and where needed passed back out in the "wrong" format. The out I think is only for channel passwords. So it may be the case that a channel password containing unicode doesn't work as expected, however the bytes remain the same so TS should interpret it correctly. I've not tested this.

[TheMagnetar]

What about using std::string test = u8"test" instead of wstring?
https://en.cppreference.com/w/cpp/language/string_literal

[tbeswick96]

What about using std::string test = u8"test" instead of wstring?
en.cppreference.com/w/cpp/language/string_literal

u8, as far as i can see, can only be used for literals, so that doesn't help much for getting the string from a variable

[TheMagnetar]

Great stuff! only minor changes. The PR looks good but I would like to see how the mumble plugin supports it, before merging this branch into master.

[tbeswick96]

@TheMagnetar Thanks, I don't have Mumble though so I can't test this with that, someone else with that all setup will need to lend a hand with that

[TheMagnetar]

For sure, this is in our hands atm. Thanks for the PR @tbeswick96

[jonpas]

Mumble compatibility branch here: https://github.com/IDI-Systems/acre2/tree/mumble-unicode

Tried with Test lığı as server name and it switched correctly on Mumble. However on TeamSpeak it moves me to the wrong channel (just uses first one that contains "ACRE" it seems). Could use another set of eyes.

[jonpas]

Did anyone get a chance to test this with my example? @tbeswick96

[tbeswick96]

I've not forgotten about this, just really busy. Intending to try and get this done in a few weeks