-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension - Handle stereo audio from TeamSpeak (cherry pick) #1240
Conversation
@@ -8,6 +8,7 @@ | |||
|
|||
#include <cmath> | |||
#pragma comment(lib, "x3daudio.lib") | |||
#pragma comment(lib, "xaudio2.lib") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not fully sure why this is now required, it's unrelated to pr but need to build on VS17.6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't need that on VS17.5. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error
2>ACRE2Core.lib(FilterPosition.obj) : error LNK2019: unresolved external symbol __imp_X3DAudioInitialize referenced in function "public: enum acre::Result __cdecl CFilterPosition::process(short *,int,int,unsigned int,class CSoundMixdownEffect *)" (?process@CFilterPosition@@QEAA?AW4Result@acre@@PEAFHHIPEAVCSoundMixdownEffect@@@Z)
2>ACRE2Core.lib(FilterPosition.obj) : error LNK2019: unresolved external symbol __imp_X3DAudioCalculate referenced in function "public: enum acre::Result __cdecl CFilterPosition::process(short *,int,int,unsigned int,class CSoundMixdownEffect *)" (?process@CFilterPosition@@QEAA?AW4Result@acre@@PEAFHHIPEAVCSoundMixdownEffect@@@Z)
it might just be something on my machine
we could just remove the line from the pr and let it build via github automation
or fix via cmake config, but we already had a existing #pragma comment(lib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also builds with it for me, forgot to say that. So I am fine with leaving it in.
fix #1237
Cherypick the stero fix from #1105